third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h - Issue 2519403002: binding: Lets Dictionary::getPropertyNames, etc. rethrow an exception.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

Issue 2519403002: binding: Lets Dictionary::getPropertyNames, etc. rethrow an exception. (Closed)

Patch Set: Addressed review comments. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/payments/PaymentRequest.cpp ('k') | third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2012 Google Inc. All rights reserved.	2 * Copyright (C) 2012 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 *	7 *

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 63 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
74 static RTCPeerConnection* create(ExecutionContext*,	74 static RTCPeerConnection* create(ExecutionContext*,

75 const RTCConfiguration&,	75 const RTCConfiguration&,

76 const Dictionary&,	76 const Dictionary&,

77 ExceptionState&);	77 ExceptionState&);

78 ~RTCPeerConnection() override;	78 ~RTCPeerConnection() override;

79	79

80 ScriptPromise createOffer(ScriptState*, const RTCOfferOptions&);	80 ScriptPromise createOffer(ScriptState*, const RTCOfferOptions&);

81 ScriptPromise createOffer(ScriptState*,	81 ScriptPromise createOffer(ScriptState*,

82 RTCSessionDescriptionCallback*,	82 RTCSessionDescriptionCallback*,

83 RTCPeerConnectionErrorCallback*,	83 RTCPeerConnectionErrorCallback*,

84 const Dictionary&);	84 const Dictionary&,

	85 ExceptionState&);

85	86

86 ScriptPromise createAnswer(ScriptState*, const RTCAnswerOptions&);	87 ScriptPromise createAnswer(ScriptState*, const RTCAnswerOptions&);

87 ScriptPromise createAnswer(ScriptState*,	88 ScriptPromise createAnswer(ScriptState*,

88 RTCSessionDescriptionCallback*,	89 RTCSessionDescriptionCallback*,

89 RTCPeerConnectionErrorCallback*,	90 RTCPeerConnectionErrorCallback*,

90 const Dictionary&);	91 const Dictionary&);

91	92

92 ScriptPromise setLocalDescription(ScriptState*,	93 ScriptPromise setLocalDescription(ScriptState*,

93 const RTCSessionDescriptionInit&);	94 const RTCSessionDescriptionInit&);

94 ScriptPromise setLocalDescription(ScriptState*,	95 ScriptPromise setLocalDescription(ScriptState*,

(...skipping 159 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
254	255

255 bool m_stopped;	256 bool m_stopped;

256 bool m_closed;	257 bool m_closed;

257	258

258 bool m_hasDataChannels; // For RAPPOR metrics	259 bool m_hasDataChannels; // For RAPPOR metrics

259 };	260 };

260	261

261 } // namespace blink	262 } // namespace blink

262	263

263 #endif // RTCPeerConnection_h	264 #endif // RTCPeerConnection_h

OLD	NEW