binding: Lets Dictionary::getPropertyNames, etc. rethrow an exception.

third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 328 matching lines @@
         certificates.size());
     for (size_t i = 0; i < certificates.size(); ++i) {
       certificatesCopy[i] = certificates[i]->certificateShallowCopy();
     }
     webConfiguration.certificates = std::move(certificatesCopy);
   }
 
   return webConfiguration;
 }
 
-RTCOfferOptionsPlatform* parseOfferOptions(const Dictionary& options) {
+RTCOfferOptionsPlatform* parseOfferOptions(const Dictionary& options,
+                                           ExceptionState& exceptionState) {
   if (options.isUndefinedOrNull())
-    return 0;
+    return nullptr;
 
-  Vector<String> propertyNames;
-  options.getPropertyNames(propertyNames);
+  const Vector<String>& propertyNames =
+      options.getPropertyNames(exceptionState);
+  if (exceptionState.hadException())
+    return nullptr;
 
   // Treat |options| as MediaConstraints if it is empty or has "optional" or
   // "mandatory" properties for compatibility.
   // TODO(jiayl): remove constraints when RTCOfferOptions reaches Stable and
   // client code is ready.
   if (propertyNames.isEmpty() || propertyNames.contains("optional") ||
       propertyNames.contains("mandatory"))
-    return 0;
+    return nullptr;
 
   int32_t offerToReceiveVideo = -1;
   int32_t offerToReceiveAudio = -1;
   bool voiceActivityDetection = true;
   bool iceRestart = false;
 
   if (DictionaryHelper::get(options, "offerToReceiveVideo",
                             offerToReceiveVideo) &&
       offerToReceiveVideo < 0)
     offerToReceiveVideo = 0;
@@ skipping 193 matching lines @@
         context, UseCounter::RTCPeerConnectionCreateOfferOptionsOfferToReceive);
   }
   m_peerHandler->createOffer(request, convertToWebRTCOfferOptions(options));
   return promise;
 }
 
 ScriptPromise RTCPeerConnection::createOffer(
     ScriptState* scriptState,
     RTCSessionDescriptionCallback* successCallback,
     RTCPeerConnectionErrorCallback* errorCallback,
-    const Dictionary& rtcOfferOptions) {
+    const Dictionary& rtcOfferOptions,
+    ExceptionState& exceptionState) {
   DCHECK(successCallback);
   DCHECK(errorCallback);
   ExecutionContext* context = scriptState->getExecutionContext();
   UseCounter::count(
       context, UseCounter::RTCPeerConnectionCreateOfferLegacyFailureCallback);
   if (callErrorCallbackIfSignalingStateClosed(m_signalingState, errorCallback))
     return ScriptPromise::castUndefined(scriptState);
 
-  RTCOfferOptionsPlatform* offerOptions = parseOfferOptions(rtcOfferOptions);
+  RTCOfferOptionsPlatform* offerOptions =
+      parseOfferOptions(rtcOfferOptions, exceptionState);
+  if (exceptionState.hadException())
+    return ScriptPromise();
   RTCSessionDescriptionRequest* request =
       RTCSessionDescriptionRequestImpl::create(getExecutionContext(), this,
                                                successCallback, errorCallback);
 
   if (offerOptions) {
     if (offerOptions->offerToReceiveAudio() != -1 ||
         offerOptions->offerToReceiveVideo() != -1)
       UseCounter::count(
           context, UseCounter::RTCPeerConnectionCreateOfferLegacyOfferOptions);
     else
@@ skipping 888 matching lines @@
 DEFINE_TRACE(RTCPeerConnection) {
   visitor->trace(m_localStreams);
   visitor->trace(m_remoteStreams);
   visitor->trace(m_dispatchScheduledEventRunner);
   visitor->trace(m_scheduledEvents);
   EventTargetWithInlineData::trace(visitor);
   ActiveDOMObject::trace(visitor);
 }
 
 }  // namespace blink