binding: Lets Dictionary::getPropertyNames, etc. rethrow an exception.

third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 133 matching lines @@
 // https://crbug.com/579729
 const char kGoogLeakyBucket[] = "googLeakyBucket";
 const char kPowerLineFrequency[] = "googPowerLineFrequency";
 // Names used for testing.
 const char kTestConstraint1[] = "valid_and_supported_1";
 const char kTestConstraint2[] = "valid_and_supported_2";
 
 static bool parseMandatoryConstraintsDictionary(
     const Dictionary& mandatoryConstraintsDictionary,
     Vector<NameValueStringConstraint>& mandatory) {
-  HashMap<String, String> mandatoryConstraintsHashMap;
-  bool ok = mandatoryConstraintsDictionary.getOwnPropertiesAsStringHashMap(
-      mandatoryConstraintsHashMap);
-  if (!ok)
+  TrackExceptionState exceptionState;
+  const HashMap<String, String>& mandatoryConstraintsHashMap =
+      mandatoryConstraintsDictionary.getOwnPropertiesAsStringHashMap(
+          exceptionState);
+  if (exceptionState.hadException())
     return false;
 
   for (const auto& iter : mandatoryConstraintsHashMap)
     mandatory.append(NameValueStringConstraint(iter.key, iter.value));
   return true;
 }
 
 static bool parseOptionalConstraintsVectorElement(
     const Dictionary& constraint,
     Vector<NameValueStringConstraint>& optionalConstraintsVector) {
-  Vector<String> localNames;
-  bool ok = constraint.getPropertyNames(localNames);
-  if (!ok)
+  TrackExceptionState exceptionState;
+  const Vector<String>& localNames =
+      constraint.getPropertyNames(exceptionState);
+  if (exceptionState.hadException())
     return false;
   if (localNames.size() != 1)
     return false;
   const String& key = localNames[0];
   String value;
-  ok = DictionaryHelper::get(constraint, key, value);
+  bool ok = DictionaryHelper::get(constraint, key, value);
   if (!ok)
     return false;
   optionalConstraintsVector.append(NameValueStringConstraint(key, value));
   return true;
 }
 
 // Old style parser. Deprecated.
 static bool parse(const Dictionary& constraintsDictionary,
                   Vector<NameValueStringConstraint>& optional,
                   Vector<NameValueStringConstraint>& mandatory) {
   if (constraintsDictionary.isUndefinedOrNull())
     return true;
 
-  Vector<String> names;
-  bool ok = constraintsDictionary.getPropertyNames(names);
-  if (!ok)
+  TrackExceptionState exceptionState;
+  const Vector<String>& names =
+      constraintsDictionary.getPropertyNames(exceptionState);
+  if (exceptionState.hadException())
     return false;
 
   String mandatoryName("mandatory");
   String optionalName("optional");
 
-  for (Vector<String>::iterator it = names.begin(); it != names.end(); ++it) {
-    if (*it != mandatoryName && *it != optionalName)
+  for (const auto& name : names) {
+    if (name != mandatoryName && name != optionalName)
       return false;
   }
 
   if (names.contains(mandatoryName)) {
     Dictionary mandatoryConstraintsDictionary;
     bool ok = constraintsDictionary.get(mandatoryName,
                                         mandatoryConstraintsDictionary);
     if (!ok || mandatoryConstraintsDictionary.isUndefinedOrNull())
       return false;
     ok = parseMandatoryConstraintsDictionary(mandatoryConstraintsDictionary,
@@ skipping 590 matching lines @@
     MediaTrackConstraintSet element;
     convertConstraintSet(it, element);
     advancedVector.append(element);
   }
   if (!advancedVector.isEmpty())
     output.setAdvanced(advancedVector);
 }
 
 }  // namespace MediaConstraintsImpl
 }  // namespace blink