Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2519363002: [d8] Do not try to verify zero-ness of failed virtual memory allocation. (Closed)

Created:
4 years, 1 month ago by titzer
Modified:
4 years, 1 month ago
Reviewers:
Clemens Hammacher
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[d8] Do not try to verify zero-ness of failed virtual memory allocation. BUG=chromium:667603 R=clemensh@chromium.org Committed: https://crrev.com/5a1fbe24ba7052b410a09695e0bed3ac571e0ac4 Cr-Commit-Position: refs/heads/master@{#41174}

Patch Set 1 #

Patch Set 2 : Dont do slice on the result array #

Patch Set 3 : [d8] Do not try to verify zero-ness of failed virtual memory allocation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M src/d8.cc View 1 2 1 chunk +7 lines, -4 lines 0 comments Download
A test/mjsunit/regress/regress-667603.js View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
titzer
4 years, 1 month ago (2016-11-22 10:09:31 UTC) #1
Clemens Hammacher
lgtm
4 years, 1 month ago (2016-11-22 10:11:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519363002/20001
4 years, 1 month ago (2016-11-22 11:55:23 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/16623) v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
4 years, 1 month ago (2016-11-22 11:57:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519363002/40001
4 years, 1 month ago (2016-11-22 12:03:25 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-22 12:36:26 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 12:36:47 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5a1fbe24ba7052b410a09695e0bed3ac571e0ac4
Cr-Commit-Position: refs/heads/master@{#41174}

Powered by Google App Engine
This is Rietveld 408576698