<webview> Fix crash when closing chrome://chrome-signin

chrome/browser/apps/guest_view/web_view_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <queue>
 #include <set>
 #include <utility>
 
 #include "base/callback_helpers.h"
 #include "base/files/file_util.h"
@@ skipping 21 matching lines @@
 #include "chrome/browser/download/download_service_factory.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
 #include "chrome/browser/pdf/pdf_extension_test_util.h"
 #include "chrome/browser/prerender/prerender_link_manager.h"
 #include "chrome/browser/prerender/prerender_link_manager_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/renderer_context_menu/render_view_context_menu.h"
 #include "chrome/browser/renderer_context_menu/render_view_context_menu_test_util.h"
 #include "chrome/browser/task_manager/task_manager_browsertest_util.h"
 #include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/browser_dialogs.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "components/content_settings/core/browser/host_content_settings_map.h"
 #include "components/guest_view/browser/guest_view_manager.h"
 #include "components/guest_view/browser/guest_view_manager_delegate.h"
 #include "components/guest_view/browser/guest_view_manager_factory.h"
 #include "components/guest_view/browser/test_guest_view_manager.h"
 #include "content/public/browser/ax_event_notification_details.h"
 #include "content/public/browser/gpu_data_manager.h"
@@ skipping 3801 matching lines @@
   gfx::Point embedder_origin =
       GetEmbedderWebContents()->GetContainerBounds().origin();
   guest_rect.Offset(-embedder_origin.x(), -embedder_origin.y());
 
   // Generate and send synthetic touch event.
   content::SimulateTouchPressAt(GetEmbedderWebContents(),
                                 guest_rect.CenterPoint());
   EXPECT_TRUE(aura_webview->HasFocus());
 }
 #endif
+
+class ChromeSignInWebViewTest : public WebViewTestBase {

[Charlie Reis, 2016/11/23 23:45:24]

Maybe add a comment that this runs with the OOPIF version of WebViews?  It's
easy to miss in the details below.

[avallee, 2016/11/24 17:53:58]

Done.

+ public:
+  ChromeSignInWebViewTest() {}
+  ~ChromeSignInWebViewTest() override {}
+
+ protected:
+  void SetUpCommandLine(base::CommandLine* command_line) override {
+    command_line->AppendSwitchASCII(
+        switches::kEnableFeatures,
+        ::features::kGuestViewCrossProcessFrames.name);
+  }
+
+  void WaitForWebViewInDom() {
+    auto* web_contents = browser()->tab_strip_model()->GetActiveWebContents();
+    auto* script =
+        "var count = 10;"
+        "var interval;"
+        "interval = setInterval(function(){"
+        "  if (document.getElementsByTagName('webview').length) {"
+        "    document.title = 'success';"
+        "    console.log('FOUND webview');"
+        "    clearInterval(interval);"
+        "  } else if (count == 0) {"
+        "    document.title = 'error';"
+        "    clearInterval(interval);"
+        "  } else {"
+        "    count -= 1;"
+        "  }"
+        "}, 1000);";
+    ExecuteScriptWaitForTitle(web_contents, script, "success");
+  }
+};
+
+
+// This verifies the fix for http://crbug.com/667708.
+IN_PROC_BROWSER_TEST_F(ChromeSignInWebViewTest,
+                       ClosingChromeSignInShouldNotCrash) {
+  GURL signin_url{"chrome://chrome-signin"};
+
+  AddTabAtIndex(0, signin_url, ui::PAGE_TRANSITION_TYPED);
+  AddTabAtIndex(1, signin_url, ui::PAGE_TRANSITION_TYPED);
+  WaitForWebViewInDom();
+
+  chrome::CloseTab(browser());
+}