Add CHECK's to debug QuicStreamSequencerBuffer in weird state. Add a destruction indicator to detec…

net/quic/core/quic_stream_sequencer_buffer.h

Index: net/quic/core/quic_stream_sequencer_buffer.h
diff --git a/net/quic/core/quic_stream_sequencer_buffer.h b/net/quic/core/quic_stream_sequencer_buffer.h
index 9549d1fbd64a0b8ed90037fb73adac10217581d3..59d071e77be9fbec90bb9978858ff93771c1fb65 100644
--- a/net/quic/core/quic_stream_sequencer_buffer.h
+++ b/net/quic/core/quic_stream_sequencer_buffer.h
@@ -248,6 +248,10 @@ class NET_EXPORT_PRIVATE QuicStreamSequencerBuffer {
   // Stores all the buffered frames' start offset, length and arrival time.
   std::map<QuicStreamOffset, FrameInfo> frame_arrival_time_map_;
 
+  // For debugging use after free, assigned to 123456 in constructor and 654321
+  // in destructor. As long as it's not 123456, this means use after free.

[Ryan Hamilton, 2016/11/23 20:42:40]

Either use after free, or memory corruption.

[danzh1, 2016/11/23 21:39:24]

Done.

+  int32_t destruction_indicator_;
+
   DISALLOW_COPY_AND_ASSIGN(QuicStreamSequencerBuffer);
 };
 }  // namespace net