Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Unified Diff: src/ast/scopes.cc

Issue 2519333005: Revert of [parser] Fix scopes in rewriting of for-of and destructuring assignments. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast/scopes.h ('k') | src/parsing/parser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/scopes.cc
diff --git a/src/ast/scopes.cc b/src/ast/scopes.cc
index 8b1e0cc005bfa57feac550b4a9ae3ac67d9ff955..c150336668545eb1a8bf78b3af3823f70bb476c1 100644
--- a/src/ast/scopes.cc
+++ b/src/ast/scopes.cc
@@ -634,36 +634,6 @@
variables_.Add(zone(), function_);
}
return function_;
-}
-
-bool Scope::HasBeenRemoved() const {
- // TODO(neis): Store this information somewhere instead of calculating it.
-
- if (is_declaration_scope()) return false;
- DCHECK(is_block_scope());
-
- Scope* parent = outer_scope();
- if (parent == nullptr) {
- DCHECK(is_script_scope());
- return false;
- }
-
- Scope* sibling = parent->inner_scope();
- for (; sibling != nullptr; sibling = sibling->sibling()) {
- if (sibling == this) return false;
- }
-
- DCHECK_NULL(inner_scope_);
- return true;
-}
-
-Scope* Scope::GetUnremovedScope() {
- Scope* scope = this;
- while (scope != nullptr && scope->HasBeenRemoved()) {
- scope = scope->outer_scope();
- }
- DCHECK_NOT_NULL(scope);
- return scope;
}
Scope* Scope::FinalizeBlockScope() {
« no previous file with comments | « src/ast/scopes.h ('k') | src/parsing/parser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698