chrome/test/chromedriver/chrome/chrome_impl.cc - Issue 251933005: [ChromeDriver] Support mobile emulation on desktop Chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/chrome_impl.cc

Issue 251933005: [ChromeDriver] Support mobile emulation on desktop Chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/chromedriver/capabilities_unittest.cc ('K') | « chrome/test/chromedriver/chrome/chrome_desktop_impl.cc ('k') | chrome/test/chromedriver/chrome/device_metrics.h » ('j') | chrome/test/chromedriver/chrome/device_metrics.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/chrome_impl.cc

diff --git a/chrome/test/chromedriver/chrome/chrome_impl.cc b/chrome/test/chromedriver/chrome/chrome_impl.cc

index f0b87d653af8bf53d3b3f224e91f8bf8e1afbcee..2790a10d5724276f6e84a6ba96bfa50a9eec6833 100644

--- a/chrome/test/chromedriver/chrome/chrome_impl.cc

+++ b/chrome/test/chromedriver/chrome/chrome_impl.cc

@@ -83,7 +83,10 @@ Status ChromeImpl::GetWebViewIds(std::list<std::string>* web_view_ids) {

// OnConnected will fire when DevToolsClient connects later.

}

web_views_.push_back(make_linked_ptr(new WebViewImpl(

- view.id, devtools_http_client_->browser_info(), client.Pass())));

+ view.id,

+ devtools_http_client_->browser_info(),

+ client.Pass(),

+ devtools_http_client_->device_metrics_.get())));

}