chrome/test/chromedriver/chrome_launcher.cc - Issue 251933005: [ChromeDriver] Support mobile emulation on desktop Chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome_launcher.cc

Issue 251933005: [ChromeDriver] Support mobile emulation on desktop Chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Convert Capability to mobileEmulation; add integration- and unit-tests Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/chromedriver/capabilities.cc ('K') | « chrome/test/chromedriver/chrome/web_view_impl.cc ('k') | chrome/test/chromedriver/client/chromedriver.py » ('j') | chrome/test/chromedriver/test/webserver.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome_launcher.cc

diff --git a/chrome/test/chromedriver/chrome_launcher.cc b/chrome/test/chromedriver/chrome_launcher.cc

index ffc24283a8ccb1c37071241c1e607d0b4b081a5f..ce3f67ddd4ac9eaf535d81d8a95b950f55c06f8d 100644

--- a/chrome/test/chromedriver/chrome_launcher.cc

+++ b/chrome/test/chromedriver/chrome_launcher.cc

@@ -313,12 +313,15 @@ Status LaunchDesktopChrome(

}

return status;

}

+ scoped_ptr<DeviceMetrics> device_metrics(

+ new DeviceMetrics(capabilities.device_metrics));

scoped_ptr<ChromeDesktopImpl> chrome_desktop(

new ChromeDesktopImpl(devtools_client.Pass(),

devtools_event_listeners,

port_reservation.Pass(),

process,

command,

+ device_metrics.Pass(),

&user_data_dir,

&extension_dir));

for (size_t i = 0; i < extension_bg_pages.size(); ++i) {