chrome/test/chromedriver/chrome/web_view_impl.h - Issue 251933005: [ChromeDriver] Support mobile emulation on desktop Chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/web_view_impl.h

Issue 251933005: [ChromeDriver] Support mobile emulation on desktop Chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Convert Capability to mobileEmulation; add integration- and unit-tests Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/chromedriver/capabilities.cc ('K') | « chrome/test/chromedriver/chrome/web_view.h ('k') | chrome/test/chromedriver/chrome/web_view_impl.cc » ('j') | chrome/test/chromedriver/test/webserver.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/web_view_impl.h

diff --git a/chrome/test/chromedriver/chrome/web_view_impl.h b/chrome/test/chromedriver/chrome/web_view_impl.h

index df33053c03fa1e504c12a657fddf60bfb7f04424..ac0aae34e51c0d1908c57c897593e7cf19b36944 100644

--- a/chrome/test/chromedriver/chrome/web_view_impl.h

+++ b/chrome/test/chromedriver/chrome/web_view_impl.h

@@ -25,6 +25,7 @@ class DevToolsClient;

class DomTracker;

class FrameTracker;

class GeolocationOverrideManager;

+class DeviceMetricsOverrideManager;

class HeapSnapshotTaker;

struct KeyEvent;

struct MouseEvent;

@@ -36,6 +37,10 @@ class WebViewImpl : public WebView {

WebViewImpl(const std::string& id,

const BrowserInfo* browser_info,

scoped_ptr<DevToolsClient> client);

+ WebViewImpl(const std::string& id,

+ const BrowserInfo* browser_info,

+ scoped_ptr<DevToolsClient> client,

+ DeviceMetrics* device_metrics);

virtual ~WebViewImpl();

// Overridden from WebView:

@@ -105,6 +110,7 @@ class WebViewImpl : public WebView {

scoped_ptr<FrameTracker> frame_tracker_;

scoped_ptr<NavigationTracker> navigation_tracker_;

scoped_ptr<JavaScriptDialogManager> dialog_manager_;

+ scoped_ptr<DeviceMetricsOverrideManager> device_metrics_override_manager_;

scoped_ptr<GeolocationOverrideManager> geolocation_override_manager_;

scoped_ptr<HeapSnapshotTaker> heap_snapshot_taker_;

scoped_ptr<DebuggerTracker> debugger_;