chrome/test/chromedriver/chrome/devtools_http_client.cc - Issue 251933005: [ChromeDriver] Support mobile emulation on desktop Chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/devtools_http_client.cc

Issue 251933005: [ChromeDriver] Support mobile emulation on desktop Chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Convert Capability to mobileEmulation; add integration- and unit-tests Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/chromedriver/capabilities.cc ('K') | « chrome/test/chromedriver/chrome/device_metrics_override_manager_unittest.cc ('k') | chrome/test/chromedriver/chrome/web_view.h » ('j') | chrome/test/chromedriver/test/webserver.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/devtools_http_client.cc

diff --git a/chrome/test/chromedriver/chrome/devtools_http_client.cc b/chrome/test/chromedriver/chrome/devtools_http_client.cc

index 2d380a8490ba2b4a581591b06d779e8b079ca2ff..9b17bcc47e98de1ed1ef9bc8c908873fe8ee6cd7 100644

--- a/chrome/test/chromedriver/chrome/devtools_http_client.cc

+++ b/chrome/test/chromedriver/chrome/devtools_http_client.cc

@@ -248,7 +248,7 @@ Status DevToolsHttpClient::CloseFrontends(const std::string& for_client_id) {

*it,

base::Bind(&FakeCloseFrontends)));

scoped_ptr<WebViewImpl> web_view(

- new WebViewImpl(*it, &browser_info_, client.Pass()));

+ new WebViewImpl(*it, &browser_info_, client.Pass(), NULL));

status = web_view->ConnectIfNecessary();

// Ignore disconnected error, because the debugger might have closed when