chrome/test/chromedriver/chrome/device_metrics.h - Issue 251933005: [ChromeDriver] Support mobile emulation on desktop Chrome.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/chromedriver/chrome/device_metrics.h

Issue 251933005: [ChromeDriver] Support mobile emulation on desktop Chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/test/chromedriver/capabilities_unittest.cc ('K') | « chrome/test/chromedriver/chrome/chrome_impl.cc ('k') | chrome/test/chromedriver/chrome/device_metrics.cc » ('j') | chrome/test/chromedriver/chrome/device_metrics.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_TEST_CHROMEDRIVER_CHROME_DEVICE_METRICS_H_

	6 #define CHROME_TEST_CHROMEDRIVER_CHROME_DEVICE_METRICS_H_

	7

	8 class DeviceMetrics {
	samuong 2014/05/09 17:58:54 I think it was OK having this as a struct, otherwi I think it was OK having this as a struct, otherwise we'd have to name the member variables differently and create a whole set of accessor functions. Rather than check if width<0, can't we just check whether device_metrics==NULL? (this might involve using a scoped_ptr in Capabilities) sam.rawlins 2014/05/16 21:09:38 Done. Show quoted text On 2014/05/09 17:58:54, samuong wrote: > I think it was OK having this as a struct, otherwise we'd have to name the > member variables differently and create a whole set of accessor functions. > > Rather than check if width<0, can't we just check whether device_metrics==NULL? > (this might involve using a scoped_ptr in Capabilities) Done.
	9 public:

	10 DeviceMetrics();

	11 DeviceMetrics(int width, int height, double device_scale_factor);

	12 ~DeviceMetrics();

	13

	14 bool IsValid() const;

	15

	16 int width;

	17 int height;

	18 double device_scale_factor;

	19 bool emulate_viewport;

	20 bool fit_window;

	21 bool text_autosizing;

	22 double font_scale_factor;

	23 };

	24

	25 #endif // CHROME_TEST_CHROMEDRIVER_CHROME_DEVICE_METRICS_H_

OLD	NEW