Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2519303002: X87: [x86] Also deal with holey arrays in the Apply builtin. (Closed)

Created:
4 years, 1 month ago by zhengxing.li
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [x86] Also deal with holey arrays in the Apply builtin. port d4f01b8a65ec02250c3f2b52b9a5e335ff513d98 (r41108) original commit message: Add fast paths for holey smi and object arrays to Function.prototype.apply, Reflect.apply and Reflect.construct. BUG= Committed: https://crrev.com/7d230e27bca58fffef1b56f7063e6b1543261269 Cr-Commit-Position: refs/heads/master@{#41203}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -9 lines) Patch
M src/builtins/x87/builtins-x87.cc View 4 chunks +40 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
zhengxing.li
PTAL, thanks!
4 years, 1 month ago (2016-11-22 03:29:59 UTC) #2
chunyang.dai
lgtm
4 years, 1 month ago (2016-11-22 08:05:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519303002/1
4 years ago (2016-11-23 06:32:27 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years ago (2016-11-23 06:32:29 UTC) #7
Benedikt Meurer
LGTM.
4 years ago (2016-11-23 06:38:18 UTC) #8
zhengxing.li
On 2016/11/23 06:38:18, Benedikt Meurer wrote: > LGTM. Thanks, Meurer!
4 years ago (2016-11-23 06:41:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519303002/1
4 years ago (2016-11-23 06:41:47 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 06:59:09 UTC) #13
commit-bot: I haz the power
4 years ago (2016-11-23 06:59:26 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d230e27bca58fffef1b56f7063e6b1543261269
Cr-Commit-Position: refs/heads/master@{#41203}

Powered by Google App Engine
This is Rietveld 408576698