Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 2519283002: ozone-mus: Fix detecting displays on device in mustash. (Closed)

Created:
4 years, 1 month ago by sadrul
Modified:
4 years, 1 month ago
Reviewers:
rjkroege
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone-mus: Fix detecting displays on device in mustash. crrev.com/429173 introduces a separate OnGpuProcessLaunched() to GpuThreadObserver, which performs some of the initialization in the drm backend. Update the mus-proxy in ozone to make sure this new function is invoked in the observers before OnGpuThreadReady. BUG=665544 Committed: https://crrev.com/89f115100afb5478a1da2c58baa5c0ef5852fd81 Cr-Commit-Position: refs/heads/master@{#433938}

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M ui/ozone/platform/drm/mus_thread_proxy.cc View 1 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
sadrul
4 years, 1 month ago (2016-11-22 02:59:12 UTC) #3
rjkroege
lgtm https://codereview.chromium.org/2519283002/diff/1/ui/ozone/platform/drm/mus_thread_proxy.cc File ui/ozone/platform/drm/mus_thread_proxy.cc (right): https://codereview.chromium.org/2519283002/diff/1/ui/ozone/platform/drm/mus_thread_proxy.cc#newcode78 ui/ozone/platform/drm/mus_thread_proxy.cc:78: observer.OnGpuProcessLaunched(); This will obviously be not quite right ...
4 years, 1 month ago (2016-11-22 17:53:32 UTC) #7
sadrul
https://codereview.chromium.org/2519283002/diff/1/ui/ozone/platform/drm/mus_thread_proxy.cc File ui/ozone/platform/drm/mus_thread_proxy.cc (right): https://codereview.chromium.org/2519283002/diff/1/ui/ozone/platform/drm/mus_thread_proxy.cc#newcode78 ui/ozone/platform/drm/mus_thread_proxy.cc:78: observer.OnGpuProcessLaunched(); On 2016/11/22 17:53:32, rjkroege wrote: > This will ...
4 years, 1 month ago (2016-11-22 18:56:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519283002/20001
4 years, 1 month ago (2016-11-22 18:58:29 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-22 19:15:56 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 19:19:06 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/89f115100afb5478a1da2c58baa5c0ef5852fd81
Cr-Commit-Position: refs/heads/master@{#433938}

Powered by Google App Engine
This is Rietveld 408576698