third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js - Issue 2519213002: [DevTools] Remove preventFollow and special checks for links throughout frontend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

Issue 2519213002: [DevTools] Remove preventFollow and special checks for links throughout frontend. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js ('k') | third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js » ('j') | third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

index 410fcba88e552e4e1ef115b08da587f876231b3e..c914b246686aab92cd7a158a072027551da39796 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

@@ -1211,10 +1211,9 @@ Elements.ElementsTreeElement = class extends TreeElement {

value = value.replace(closingPunctuationRegex, '$&\u200B');

if (value.startsWith('data:'))

value = value.trimMiddle(60);

- var anchor = node.nodeName().toLowerCase() === 'a' ? UI.createExternalLink(rewrittenHref, value, '', true) :

- Components.Linkifier.linkifyURL(rewrittenHref, value);

- anchor.preventFollow = true;

- return anchor;

+ return node.nodeName().toLowerCase() === 'a' ?

+ UI.createExternalLink(rewrittenHref, value, '', true) :

+ Components.Linkifier.linkifyURL(rewrittenHref, value, '', undefined, undefined, true);

}

if (node && (name === 'src' || name === 'href')) {