Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 2519193002: DevTools: Elements: Only lookup most used properties for properties (Closed)

Created:
4 years, 1 month ago by einbinder
Modified:
4 years ago
Reviewers:
lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-style_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Elements: Only lookup most used properties for properties If a CSS value had the same name as a CSS property and was used in autocomplete, it would get a high priority. This doesn't happen often, if at all, in practice. But it's good to guard against. BUG=none Committed: https://crrev.com/aad2447171b4472fe0189415cec493875af9af75 Cr-Commit-Position: refs/heads/master@{#435689}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js View 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
einbinder
ptal
4 years ago (2016-11-30 21:25:21 UTC) #5
lushnikov
lgtm
4 years ago (2016-11-30 21:47:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519193002/1
4 years ago (2016-12-01 20:07:29 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 20:12:30 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-01 20:16:42 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aad2447171b4472fe0189415cec493875af9af75
Cr-Commit-Position: refs/heads/master@{#435689}

Powered by Google App Engine
This is Rietveld 408576698