Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

Issue 2519163003: LayoutView's paint layer should clip to the full viewport size. (Closed)
Patch Set: Add test Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
index 26d508ee564501d5b14eaf35506be95f50cdaea7..8dff34918e0290990363a0997a55cd6d60c9d125 100644
--- a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
+++ b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
@@ -2285,7 +2285,8 @@ TEST_P(VisualViewportTest, ResizeNonCompositedAndFixedBackground) {
// Without root-layer-scrolling, the LayoutView is the size of the document
// content so invalidating it for background-attachment: fixed
// overinvalidates as we should only need to invalidate the viewport size.
- int expectedHeight = rootLayerScrolling ? 430 : 1000;
+ // With root-layer-scrolling, we should invalidate the entire viewport height.
+ int expectedHeight = rootLayerScrolling ? pageHeight : 1000;
// The entire viewport should have been invalidated.
EXPECT_EQ(1u, rasterInvalidations->size());
« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayer.cpp ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698