third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp - Issue 2519163003: LayoutView's paint layer should clip to the full viewport size.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

Issue 2519163003: LayoutView's paint layer should clip to the full viewport size. (Closed)

Patch Set: Fix test Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutView.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayer.cpp » ('j') | third_party/WebKit/Source/core/paint/PaintLayer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp b/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

index 06a015ef2c4a8f2bacf9372b1d4ef78b07dbd2e5..f1e4f3954e713c0dfb2ce8037fdce48615c569a3 100644

--- a/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

@@ -831,7 +831,14 @@ void PaintLayerCompositor::setIsInWindow(bool isInWindow) {

void PaintLayerCompositor::updateRootLayerPosition() {

if (m_rootContentLayer) {

- const IntRect& documentRect = m_layoutView.documentRect();

+ IntRect documentRect = m_layoutView.documentRect();

+ // Ensure the root content layer is at least the size of the outer viewport

+ // so that we don't end up clipping position: fixed elements if the

+ // document is smaller.

+ documentRect.unite(IntRect(documentRect.location(),

+ m_layoutView.frameView()->visibleContentSize()));

m_rootContentLayer->setSize(FloatSize(documentRect.size()));

m_rootContentLayer->setPosition(documentRect.location());

}