Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutView.cpp

Issue 2519163003: LayoutView's paint layer should clip to the full viewport size. (Closed)
Patch Set: Add test Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc.
4 * All rights reserved. 4 * All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 289 matching lines...) Expand 10 before | Expand all | Expand 10 after
300 // In normal compositing mode, LayoutView doesn't actually apply clipping 300 // In normal compositing mode, LayoutView doesn't actually apply clipping
301 // on its descendants. Instead their visual overflow is propagated to 301 // on its descendants. Instead their visual overflow is propagated to
302 // compositor()->m_rootContentLayer for accelerated scrolling. 302 // compositor()->m_rootContentLayer for accelerated scrolling.
303 return layoutOverflowRect(); 303 return layoutOverflowRect();
304 } 304 }
305 305
306 LayoutRect LayoutView::localVisualRect() const { 306 LayoutRect LayoutView::localVisualRect() const {
307 // TODO(wangxianzhu): This is only required without rootLayerScrolls (though 307 // TODO(wangxianzhu): This is only required without rootLayerScrolls (though
308 // it is also correct but unnecessary with rootLayerScrolls) because of the 308 // it is also correct but unnecessary with rootLayerScrolls) because of the
309 // special LayoutView overflow model. 309 // special LayoutView overflow model.
310 return visualOverflowRect(); 310 LayoutRect rect = visualOverflowRect();
311 rect.unite(LayoutRect(rect.location(), viewRect().size()));
312 return rect;
311 } 313 }
312 314
313 void LayoutView::mapLocalToAncestor(const LayoutBoxModelObject* ancestor, 315 void LayoutView::mapLocalToAncestor(const LayoutBoxModelObject* ancestor,
314 TransformState& transformState, 316 TransformState& transformState,
315 MapCoordinatesFlags mode) const { 317 MapCoordinatesFlags mode) const {
316 if (!ancestor && mode & UseTransforms && shouldUseTransformFromContainer(0)) { 318 if (!ancestor && mode & UseTransforms && shouldUseTransformFromContainer(0)) {
317 TransformationMatrix t; 319 TransformationMatrix t;
318 getTransformFromContainer(0, LayoutSize(), t); 320 getTransformFromContainer(0, LayoutSize(), t);
319 transformState.applyTransform(t); 321 transformState.applyTransform(t);
320 } 322 }
(...skipping 717 matching lines...) Expand 10 before | Expand all | Expand 10 after
1038 if (block) 1040 if (block)
1039 block->adjustChildDebugRect(rect); 1041 block->adjustChildDebugRect(rect);
1040 1042
1041 rect.setWidth(LayoutUnit(viewWidth(IncludeScrollbars))); 1043 rect.setWidth(LayoutUnit(viewWidth(IncludeScrollbars)));
1042 rect.setHeight(LayoutUnit(viewHeight(IncludeScrollbars))); 1044 rect.setHeight(LayoutUnit(viewHeight(IncludeScrollbars)));
1043 1045
1044 return rect; 1046 return rect;
1045 } 1047 }
1046 1048
1047 } // namespace blink 1049 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698