Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2519143002: Store index into AnalysisDriverResolvedUnit and return in AnalysisResult. (Closed)

Created:
4 years, 1 month ago by scheglov
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Store index into AnalysisDriverResolvedUnit and return in AnalysisResult. R=paulberry@google.com, brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/782a4032152013e12f667aefeb97de8e76abf7c2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -43 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 8 chunks +38 lines, -41 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.dart View 6 chunks +33 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.fbs View Binary file 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 3 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 1 month ago (2016-11-21 20:00:03 UTC) #1
Paul Berry
lgtm
4 years, 1 month ago (2016-11-21 20:04:57 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 782a4032152013e12f667aefeb97de8e76abf7c2 (presubmit successful).
4 years, 1 month ago (2016-11-21 20:08:28 UTC) #4
Brian Wilkerson
4 years, 1 month ago (2016-11-21 20:22:31 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698