Enable SecureSocket on Fuchsia using BoringSSL

Enable SecureSocket on Fuchsia using BoringSSL and compiled-in certificates from dart-sdk/root_certificates.

Implement OS::CurrentTimeMicros in terms of gettimeofday.

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/8d57e3d54078423af909c664bd1595c29e0f9059

[rmacnak, 2016-11-23 02:12:37]

Requires copying sdk/third_party/root_certificates to
fuchsia/third_party/root_certificates.

Yields:
Trusting compiled-in roots
SSL_connect status: -1
SSL_connect error: 2
Failed: Handshake error in client status 0ERROR: 268435581 error:1000007d:SSL
routines:OPENSSL_internal:CERTIFICATE_VERIFY_FAILED
SocketException: HandshakeException: Handshake error in client (OS Error: errno
= 0)

[rmacnak, 2016-11-23 18:10:21]

Description was changed from

==========
WIP: BoringSSL
==========

to

==========
Enable SecureSocket on Fuchsia using BoringSSL and compiled-in certificates from
dart-sdk/root_certificates.

Implement OS::CurrentTimeMicros in terms of gettimeofday.
==========

[rmacnak, 2016-11-23 18:12:59]

On 2016/11/23 02:12:37, rmacnak wrote:
> Requires copying sdk/third_party/root_certificates to
> fuchsia/third_party/root_certificates.
> 
> Yields:
> Trusting compiled-in roots
> SSL_connect status: -1
> SSL_connect error: 2
> Failed: Handshake error in client status 0ERROR: 268435581 error:1000007d:SSL
> routines:OPENSSL_internal:CERTIFICATE_VERIFY_FAILED
> SocketException: HandshakeException: Handshake error in client (OS Error:
errno
> = 0)

We discovered this is due to BoringSSL thinking the date was 1970. Filed US-96.

[rmacnak, 2016-11-23 18:13:44]

Description was changed from

==========
Enable SecureSocket on Fuchsia using BoringSSL and compiled-in certificates from
dart-sdk/root_certificates.

Implement OS::CurrentTimeMicros in terms of gettimeofday.
==========

to

==========
Enable SecureSocket on Fuchsia using BoringSSL and compiled-in certificates from
dart-sdk/root_certificates.

Implement OS::CurrentTimeMicros in terms of gettimeofday.
==========

[rmacnak, 2016-11-23 18:14:44]

rmacnak@google.com changed reviewers:
+ asiva@google.com

[siva, 2016-11-23 18:36:04]

lgtm

https://codereview.chromium.org/2519133005/diff/80001/runtime/bin/secure_sock...
File runtime/bin/secure_socket_boringssl.cc (right):

https://codereview.chromium.org/2519133005/diff/80001/runtime/bin/secure_sock...
runtime/bin/secure_socket_boringssl.cc:62: static const bool SSL_LOG_STATUS =
true;
Something you turned on for debugging and not needed in the check-in?

https://codereview.chromium.org/2519133005/diff/80001/runtime/tests/vm/dart/h...
File runtime/tests/vm/dart/hello_fuchsia_test.dart (right):

https://codereview.chromium.org/2519133005/diff/80001/runtime/tests/vm/dart/h...
runtime/tests/vm/dart/hello_fuchsia_test.dart:337: // built-in root certificate
authority.
This comment here is probably not needed as you are just testing
http.

https://codereview.chromium.org/2519133005/diff/80001/runtime/tests/vm/dart/h...
runtime/tests/vm/dart/hello_fuchsia_test.dart:410: print("testGoogleHttps
done");
Should we comment out this under US-96?

https://codereview.chromium.org/2519133005/diff/80001/runtime/tests/vm/dart/h...
runtime/tests/vm/dart/hello_fuchsia_test.dart:413: print(new DateTime.now());
Is this line added for debugging?

[rmacnak, 2016-11-23 18:43:02]

https://codereview.chromium.org/2519133005/diff/80001/runtime/bin/secure_sock...
File runtime/bin/secure_socket_boringssl.cc (right):

https://codereview.chromium.org/2519133005/diff/80001/runtime/bin/secure_sock...
runtime/bin/secure_socket_boringssl.cc:62: static const bool SSL_LOG_STATUS =
true;
On 2016/11/23 18:36:04, siva wrote:
> Something you turned on for debugging and not needed in the check-in?

Flipped back off.

https://codereview.chromium.org/2519133005/diff/80001/runtime/tests/vm/dart/h...
File runtime/tests/vm/dart/hello_fuchsia_test.dart (right):

https://codereview.chromium.org/2519133005/diff/80001/runtime/tests/vm/dart/h...
runtime/tests/vm/dart/hello_fuchsia_test.dart:337: // built-in root certificate
authority.
On 2016/11/23 18:36:04, siva wrote:
> This comment here is probably not needed as you are just testing
> http.

Done.

https://codereview.chromium.org/2519133005/diff/80001/runtime/tests/vm/dart/h...
runtime/tests/vm/dart/hello_fuchsia_test.dart:410: print("testGoogleHttps
done");
On 2016/11/23 18:36:04, siva wrote:
> Should we comment out this under US-96?

Done.

https://codereview.chromium.org/2519133005/diff/80001/runtime/tests/vm/dart/h...
runtime/tests/vm/dart/hello_fuchsia_test.dart:413: print(new DateTime.now());
On 2016/11/23 18:36:04, siva wrote:
> Is this line added for debugging?

Moved under testGoogleHttps with an explanation this is for debugging
certificate rejection.

[rmacnak, 2016-11-23 18:48:22]

Description was changed from

==========
Enable SecureSocket on Fuchsia using BoringSSL and compiled-in certificates from
dart-sdk/root_certificates.

Implement OS::CurrentTimeMicros in terms of gettimeofday.
==========

to

==========
Enable SecureSocket on Fuchsia using BoringSSL and compiled-in certificates from
dart-sdk/root_certificates.

Implement OS::CurrentTimeMicros in terms of gettimeofday.

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8d57e3d54078423af909c664bd1595c29e0f9059
==========

[rmacnak, 2016-11-23 18:48:23]

Committed patchset #6 (id:100001) manually as
8d57e3d54078423af909c664bd1595c29e0f9059 (presubmit successful).

[Cutch, 2016-11-23 19:31:18]

johnmccutchan@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2016-11-23 19:31:20]

DBC

https://codereview.chromium.org/2519133005/diff/100001/runtime/bin/BUILD.gn
File runtime/bin/BUILD.gn (right):

https://codereview.chromium.org/2519133005/diff/100001/runtime/bin/BUILD.gn#n...
runtime/bin/BUILD.gn:10: dart_use_fallback_root_certificates = true
why are we changing the default arguments here? Can't the Fuchsia build override
this?

https://codereview.chromium.org/2519133005/diff/100001/runtime/tests/vm/dart/...
File runtime/tests/vm/dart/hello_fuchsia_test.dart (right):

https://codereview.chromium.org/2519133005/diff/100001/runtime/tests/vm/dart/...
runtime/tests/vm/dart/hello_fuchsia_test.dart:334: Future
testGoogleHttp(SecurityContext context, String outcome) async {
how can this test fail outside of checked mode?

https://codereview.chromium.org/2519133005/diff/100001/runtime/tests/vm/dart/...
runtime/tests/vm/dart/hello_fuchsia_test.dart:343: assert('pass' == outcome);
this should be an expect so that non-checked mode checks this.