Use field.RawOwner() for initializer to keep correct script.

Use field.RawOwner() for initializer to keep correct script.

E.g.

file1:
------------
library crash;

part "file2.dart";

main() {
  print(field2);
}

crash() {
  try {
    throw "Crashing!";
  } catch(exception, stacktrace) {
    print(stacktrace);
  }
}

file2:
------------
part of crash;

var field2 = crash();


We want something like

#0      crash (whatnot/file1.dart:11:5)
#1      field2 (whatnot/file2.dart:3:14) <-- good line
#2      field2 (whatnot/file2.dart:3:5)
#3      main (whatnot/file1.dart:6:9)

and not like

#0      crash (whatnot/file1.dart:11:5)
#1      field2 (whatnot/file1.dart:3:14) <-- bad line
#2      field2 (whatnot/file2.dart:3:5)
#3      main (whatnot/file1.dart:6:9)

R=kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/f0da43445e7120b8792c220f8c34aba15ed823e3

[jensj, 2016-11-22 15:04:54]

Description was changed from

==========
Use field.RawOwner() for initializer to keep correct script.

E.g.

file1:
------------
library crash;

part "file2.dart";

main() {
  print(field2);
}

crash() {
  try {
    throw "Crashing!";
  } catch(exception, stacktrace) {
    print(stacktrace);
  }
}

file2:
------------
part of crash;

var field2 = crash();


We want something like



and not like
==========

to

==========
Use field.RawOwner() for initializer to keep correct script.

E.g.

file1:
------------
library crash;

part "file2.dart";

main() {
  print(field2);
}

crash() {
  try {
    throw "Crashing!";
  } catch(exception, stacktrace) {
    print(stacktrace);
  }
}

file2:
------------
part of crash;

var field2 = crash();


We want something like

#0      crash (whatnot/file1.dart:11:5)
#1      field2 (whatnot/file2.dart:3:14) <-- good line
#2      field2 (whatnot/file2.dart:3:5)
#3      main (whatnot/file1.dart:6:9)

and not like

#0      crash (whatnot/file1.dart:11:5)
#1      field2 (whatnot/file1.dart:3:14) <-- bad line
#2      field2 (whatnot/file2.dart:3:5)
#3      main (whatnot/file1.dart:6:9)
==========

[jensj, 2016-11-22 15:04:54]

jensj@google.com changed reviewers:
+ kmillikin@google.com

[Kevin Millikin (Google), 2016-11-23 10:40:45]

LGTM.

https://codereview.chromium.org/2519133004/diff/1/runtime/vm/kernel_reader.cc
File runtime/vm/kernel_reader.cc (right):

https://codereview.chromium.org/2519133004/diff/1/runtime/vm/kernel_reader.cc...
runtime/vm/kernel_reader.cc:710: // Use RawOwner: We also want PatchClass
(created by ClassForScriptAt)
The comment wording is strange, but I'm not sure this needs a comment anyway.

[jensj, 2016-11-23 11:39:27]

Thanks. Landing.

https://codereview.chromium.org/2519133004/diff/1/runtime/vm/kernel_reader.cc
File runtime/vm/kernel_reader.cc (right):

https://codereview.chromium.org/2519133004/diff/1/runtime/vm/kernel_reader.cc...
runtime/vm/kernel_reader.cc:710: // Use RawOwner: We also want PatchClass
(created by ClassForScriptAt)
On 2016/11/23 10:40:45, Kevin Millikin (Google) wrote:
> The comment wording is strange, but I'm not sure this needs a comment anyway.

I'll remove it.

[jensj, 2016-11-24 08:27:31]

Description was changed from

==========
Use field.RawOwner() for initializer to keep correct script.

E.g.

file1:
------------
library crash;

part "file2.dart";

main() {
  print(field2);
}

crash() {
  try {
    throw "Crashing!";
  } catch(exception, stacktrace) {
    print(stacktrace);
  }
}

file2:
------------
part of crash;

var field2 = crash();


We want something like

#0      crash (whatnot/file1.dart:11:5)
#1      field2 (whatnot/file2.dart:3:14) <-- good line
#2      field2 (whatnot/file2.dart:3:5)
#3      main (whatnot/file1.dart:6:9)

and not like

#0      crash (whatnot/file1.dart:11:5)
#1      field2 (whatnot/file1.dart:3:14) <-- bad line
#2      field2 (whatnot/file2.dart:3:5)
#3      main (whatnot/file1.dart:6:9)
==========

to

==========
Use field.RawOwner() for initializer to keep correct script.

E.g.

file1:
------------
library crash;

part "file2.dart";

main() {
  print(field2);
}

crash() {
  try {
    throw "Crashing!";
  } catch(exception, stacktrace) {
    print(stacktrace);
  }
}

file2:
------------
part of crash;

var field2 = crash();


We want something like

#0      crash (whatnot/file1.dart:11:5)
#1      field2 (whatnot/file2.dart:3:14) <-- good line
#2      field2 (whatnot/file2.dart:3:5)
#3      main (whatnot/file1.dart:6:9)

and not like

#0      crash (whatnot/file1.dart:11:5)
#1      field2 (whatnot/file1.dart:3:14) <-- bad line
#2      field2 (whatnot/file2.dart:3:5)
#3      main (whatnot/file1.dart:6:9)

R=kmillikin@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f0da43445e7120b8792c220f8c34aba15ed823e3
==========

[jensj, 2016-11-24 08:27:32]

Committed patchset #1 (id:1) manually as
f0da43445e7120b8792c220f8c34aba15ed823e3 (presubmit successful).