Chromium Code Reviews

Issue 2519093002: [cleanup] CodeStubAssembler: s/compiler::Node/Node/ (Closed)

Created:
4 years ago by Jakob Kummerow
Modified:
4 years ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] CodeStubAssembler: s/compiler::Node/Node/ Reducing visual clutter. Committed: https://crrev.com/36a17e87d86d2d978b64eb37044c9e9f98ebea67 Cr-Commit-Position: refs/heads/master@{#41187}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Stats (+490 lines, -665 lines)
M src/code-stub-assembler.h View 13 chunks +413 lines, -558 lines 0 comments
M src/code-stub-assembler.cc View 34 chunks +77 lines, -107 lines 0 comments

Messages

Total messages: 11 (5 generated)
Jakob Kummerow
PTAL.
4 years ago (2016-11-21 17:23:08 UTC) #2
Igor Sheludko
lgtm
4 years ago (2016-11-22 12:54:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519093002/20001
4 years ago (2016-11-22 15:12:08 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-22 15:38:59 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/36a17e87d86d2d978b64eb37044c9e9f98ebea67 Cr-Commit-Position: refs/heads/master@{#41187}
4 years ago (2016-11-22 15:39:17 UTC) #10
Michael Hablich
4 years ago (2016-11-23 08:24:14 UTC) #11
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2528593002/ by hablich@chromium.org.

The reason for reverting is: Blocks revert of roll blocker:
https://codereview.chromium.org/2528583002/.

Powered by Google App Engine