Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: content/browser/indexed_db/indexed_db_database.cc

Issue 2519073003: IndexedDB: IndexedDBDatabase::Create() returning db/status tuple. (Closed)
Patch Set: Swapped db/s to reflect order in tuple Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/indexed_db/indexed_db_database.cc
diff --git a/content/browser/indexed_db/indexed_db_database.cc b/content/browser/indexed_db/indexed_db_database.cc
index 85b6f9d6911e032eca78054e44ad448925585203..beb51ebfc2309d3f054a25fde1c7b3640a25513c 100644
--- a/content/browser/indexed_db/indexed_db_database.cc
+++ b/content/browser/indexed_db/indexed_db_database.cc
@@ -356,20 +356,18 @@ class IndexedDBDatabase::DeleteRequest
DISALLOW_COPY_AND_ASSIGN(DeleteRequest);
};
-scoped_refptr<IndexedDBDatabase> IndexedDBDatabase::Create(
- const base::string16& name,
- IndexedDBBackingStore* backing_store,
- IndexedDBFactory* factory,
- const Identifier& unique_identifier,
- leveldb::Status* s) {
+std::tuple<scoped_refptr<IndexedDBDatabase>, leveldb::Status>
+IndexedDBDatabase::Create(const base::string16& name,
+ IndexedDBBackingStore* backing_store,
+ IndexedDBFactory* factory,
+ const Identifier& unique_identifier) {
scoped_refptr<IndexedDBDatabase> database =
IndexedDBClassFactory::Get()->CreateIndexedDBDatabase(
name, backing_store, factory, unique_identifier);
- *s = database->OpenInternal();
- if (s->ok())
- return database;
- else
- return NULL;
+ leveldb::Status s = database->OpenInternal();
+ if (!s.ok())
+ database = nullptr;
+ return std::tie(database, s);
}
IndexedDBDatabase::IndexedDBDatabase(const base::string16& name,
« no previous file with comments | « content/browser/indexed_db/indexed_db_database.h ('k') | content/browser/indexed_db/indexed_db_database_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698