IndexedDB: IndexedDBDatabase::Create() returning db/status tuple.

content/browser/indexed_db/indexed_db_database_unittest.cc

Index: content/browser/indexed_db/indexed_db_database_unittest.cc
diff --git a/content/browser/indexed_db/indexed_db_database_unittest.cc b/content/browser/indexed_db/indexed_db_database_unittest.cc
index a13a163190341782f63d4992899764c3c66cc07b..3315276a01af1a5aa84c192411f5a469d0076d17 100644
--- a/content/browser/indexed_db/indexed_db_database_unittest.cc
+++ b/content/browser/indexed_db/indexed_db_database_unittest.cc
@@ -50,12 +50,10 @@ TEST_F(IndexedDBDatabaseTest, BackingStoreRetention) {
 
   scoped_refptr<MockIndexedDBFactory> factory = new MockIndexedDBFactory();
   leveldb::Status s;
-  scoped_refptr<IndexedDBDatabase> db =
-      IndexedDBDatabase::Create(ASCIIToUTF16("db"),
-                                backing_store.get(),
-                                factory.get(),
-                                IndexedDBDatabase::Identifier(),
-                                &s);
+  scoped_refptr<IndexedDBDatabase> db;
+  std::tie(db, s) =
+      IndexedDBDatabase::Create(ASCIIToUTF16("db"), backing_store.get(),
+                                factory.get(), IndexedDBDatabase::Identifier());
   ASSERT_TRUE(s.ok());
   EXPECT_FALSE(backing_store->HasOneRef());  // local and db
   db = NULL;
@@ -69,12 +67,10 @@ TEST_F(IndexedDBDatabaseTest, ConnectionLifecycle) {
 
   scoped_refptr<MockIndexedDBFactory> factory = new MockIndexedDBFactory();
   leveldb::Status s;

[jsbell, 2016/11/21 20:07:20]

nit: I'd flip the order here to match the tuple order.

[cmumford, 2016/11/22 16:43:19]

Done.

-  scoped_refptr<IndexedDBDatabase> db =
-      IndexedDBDatabase::Create(ASCIIToUTF16("db"),
-                                backing_store.get(),
-                                factory.get(),
-                                IndexedDBDatabase::Identifier(),
-                                &s);
+  scoped_refptr<IndexedDBDatabase> db;
+  std::tie(db, s) =
+      IndexedDBDatabase::Create(ASCIIToUTF16("db"), backing_store.get(),
+                                factory.get(), IndexedDBDatabase::Identifier());
   ASSERT_TRUE(s.ok());
   EXPECT_FALSE(backing_store->HasOneRef());  // local and db
 
@@ -123,12 +119,10 @@ TEST_F(IndexedDBDatabaseTest, ForcedClose) {
 
   scoped_refptr<MockIndexedDBFactory> factory = new MockIndexedDBFactory();
   leveldb::Status s;
-  scoped_refptr<IndexedDBDatabase> database =
-      IndexedDBDatabase::Create(ASCIIToUTF16("db"),
-                                backing_store.get(),
-                                factory.get(),
-                                IndexedDBDatabase::Identifier(),
-                                &s);
+  scoped_refptr<IndexedDBDatabase> database;
+  std::tie(database, s) =
+      IndexedDBDatabase::Create(ASCIIToUTF16("db"), backing_store.get(),
+                                factory.get(), IndexedDBDatabase::Identifier());
   ASSERT_TRUE(s.ok());
   EXPECT_FALSE(backing_store->HasOneRef());  // local and db
 
@@ -190,12 +184,10 @@ TEST_F(IndexedDBDatabaseTest, PendingDelete) {
 
   scoped_refptr<MockIndexedDBFactory> factory = new MockIndexedDBFactory();
   leveldb::Status s;
-  scoped_refptr<IndexedDBDatabase> db =
-      IndexedDBDatabase::Create(ASCIIToUTF16("db"),
-                                backing_store.get(),
-                                factory.get(),
-                                IndexedDBDatabase::Identifier(),
-                                &s);
+  scoped_refptr<IndexedDBDatabase> db;
+  std::tie(db, s) =
+      IndexedDBDatabase::Create(ASCIIToUTF16("db"), backing_store.get(),
+                                factory.get(), IndexedDBDatabase::Identifier());
   ASSERT_TRUE(s.ok());
   EXPECT_FALSE(backing_store->HasOneRef());  // local and db
 
@@ -246,9 +238,10 @@ TEST_F(IndexedDBDatabaseTest, ConnectionRequestsNoLongerValid) {
   const int64_t transaction_id1 = 1;
   scoped_refptr<MockIndexedDBFactory> factory = new MockIndexedDBFactory();
   leveldb::Status s;
-  scoped_refptr<IndexedDBDatabase> db = IndexedDBDatabase::Create(
-      ASCIIToUTF16("db"), backing_store.get(), factory.get(),
-      IndexedDBDatabase::Identifier(), &s);
+  scoped_refptr<IndexedDBDatabase> db;
+  std::tie(db, s) =
+      IndexedDBDatabase::Create(ASCIIToUTF16("db"), backing_store.get(),
+                                factory.get(), IndexedDBDatabase::Identifier());
 
   // Make a connection request. This will be processed immediately.
   scoped_refptr<MockIndexedDBCallbacks> request1(new MockIndexedDBCallbacks());
@@ -352,11 +345,9 @@ class IndexedDBDatabaseOperationTest : public testing::Test {
   void SetUp() override {
     backing_store_ = new IndexedDBFakeBackingStore();
     leveldb::Status s;
-    db_ = IndexedDBDatabase::Create(ASCIIToUTF16("db"),
-                                    backing_store_.get(),
-                                    factory_.get(),
-                                    IndexedDBDatabase::Identifier(),
-                                    &s);
+    std::tie(db_, s) = IndexedDBDatabase::Create(
+        ASCIIToUTF16("db"), backing_store_.get(), factory_.get(),
+        IndexedDBDatabase::Identifier());
     ASSERT_TRUE(s.ok());
 
     request_ = new MockIndexedDBCallbacks();