IndexedDB: IndexedDBDatabase::Create() returning db/status tuple.

IndexedDB: IndexedDBDatabase::Create() returning db/status tuple.

Committed: https://crrev.com/c1d866ea9c75932a5166394af59076fd1a2a7309
Cr-Commit-Position: refs/heads/master@{#433919}

[cmumford, 2016-11-21 19:58:47]

cmumford@chromium.org changed reviewers:
+ jsbell@chromium.org

[cmumford, 2016-11-21 19:58:48]

This is just an experiment to see if returning tuples is more readable then a
return value + output parameter. What do you think?

[jsbell, 2016-11-21 20:07:20]

I'm a fan.

https://codereview.chromium.org/2519073003/diff/20001/content/browser/indexed...
File content/browser/indexed_db/indexed_db_database.cc (right):

https://codereview.chromium.org/2519073003/diff/20001/content/browser/indexed...
content/browser/indexed_db/indexed_db_database.cc:361: IndexedDBBackingStore*
backing_store,
While you're here, change these to take scoped_refptr<>

https://codereview.chromium.org/2519073003/diff/20001/content/browser/indexed...
File content/browser/indexed_db/indexed_db_database_unittest.cc (right):

https://codereview.chromium.org/2519073003/diff/20001/content/browser/indexed...
content/browser/indexed_db/indexed_db_database_unittest.cc:69: leveldb::Status
s;
nit: I'd flip the order here to match the tuple order.

[jsbell, 2016-11-21 20:07:24]

lgtm

[cmumford, 2016-11-22 16:42:56]

Description was changed from

==========
IndexedDB: IndexedDBDatabase::Create() returning db/status tuple.

COMMIT=false
==========

to

==========
IndexedDB: IndexedDBDatabase::Create() returning db/status tuple.
==========

[cmumford, 2016-11-22 16:43:19]

https://codereview.chromium.org/2519073003/diff/20001/content/browser/indexed...
File content/browser/indexed_db/indexed_db_database.cc (right):

https://codereview.chromium.org/2519073003/diff/20001/content/browser/indexed...
content/browser/indexed_db/indexed_db_database.cc:361: IndexedDBBackingStore*
backing_store,
On 2016/11/21 20:07:20, jsbell wrote:
> While you're here, change these to take scoped_refptr<>

Sure, I'll do that in another CL.

https://codereview.chromium.org/2519073003/diff/20001/content/browser/indexed...
File content/browser/indexed_db/indexed_db_database_unittest.cc (right):

https://codereview.chromium.org/2519073003/diff/20001/content/browser/indexed...
content/browser/indexed_db/indexed_db_database_unittest.cc:69: leveldb::Status
s;
On 2016/11/21 20:07:20, jsbell wrote:
> nit: I'd flip the order here to match the tuple order.

Done.

[cmumford, 2016-11-22 17:34:54]

The CQ bit was checked by cmumford@chromium.org

[cmumford, 2016-11-22 17:34:54]

The patchset sent to the CQ was uploaded after l-g-t-m from jsbell@chromium.org
Link to the patchset: https://codereview.chromium.org/2519073003/#ps40001
(title: "Swapped db/s to reflect order in tuple")

[commit-bot: I haz the power, 2016-11-22 17:35:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 18:22:37]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1479836094027260,
"parent_rev": "1545fa92df639bdf3d183569cc5d0f459ecc1577", "commit_rev":
"a0aa006d1f7b728506f3faa952bdc0197090aa90"}

[commit-bot: I haz the power, 2016-11-22 18:23:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-22 18:26:42]

Description was changed from

==========
IndexedDB: IndexedDBDatabase::Create() returning db/status tuple.
==========

to

==========
IndexedDB: IndexedDBDatabase::Create() returning db/status tuple.

Committed: https://crrev.com/c1d866ea9c75932a5166394af59076fd1a2a7309
Cr-Commit-Position: refs/heads/master@{#433919}
==========

[commit-bot: I haz the power, 2016-11-22 18:26:43]

Patchset 3 (id:??) landed as
https://crrev.com/c1d866ea9c75932a5166394af59076fd1a2a7309
Cr-Commit-Position: refs/heads/master@{#433919}