Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: components/ntp_snippets/content_suggestions_provider.h

Issue 2519053002: 📰 Let the backend trigger sign in related refreshes (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/content_suggestions_provider.h
diff --git a/components/ntp_snippets/content_suggestions_provider.h b/components/ntp_snippets/content_suggestions_provider.h
index ddb6b468a884215c4f6ecf93aa5731a5403b2e9b..2efd0aef95292ee36e40677408af6955935d3acf 100644
--- a/components/ntp_snippets/content_suggestions_provider.h
+++ b/components/ntp_snippets/content_suggestions_provider.h
@@ -119,6 +119,12 @@ class ContentSuggestionsProvider {
// from scratch.
virtual void ClearCachedSuggestions(Category category) = 0;
+ // Called when the sign in state has changed. Should be used instead of
+ // directly registering with the SignInManager so that the
+ // ContentSuggestionService can control the order of the updates between
+ // the providers and the observers.
+ virtual void OnSignInStateChanged(){};
Bernhard Bauer 2016/11/21 15:48:15 Nit: space before braces, and no semicolon at the
Marc Treib 2016/11/21 15:48:53 nit: no ";". Also, space between "()" and "{}"? A
dgn 2016/11/21 16:22:08 Done. AFAIK only the remote provider cares about
Marc Treib 2016/11/21 16:52:30 I guess it's conceivable that other providers migh
+
// Used only for debugging purposes. Retrieves suggestions for the given
// |category| that have previously been dismissed and are still stored in the
// provider. If the provider doesn't store dismissed suggestions for the given

Powered by Google App Engine
This is Rietveld 408576698