📰 Let the backend trigger sign in related refreshes

chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
index dfb61adfeb82aa7cb0ac05df47cea2cd6d61163c..05e28db295073d78747dc7281a966ecaf50978de 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
@@ -170,7 +170,7 @@ public void onItemRangeRemoved(TreeNode child, int index, int count) {
             }
         };
 
-        mSigninPromo = new SignInPromo(mRoot, this);
+        mSigninPromo = new SignInPromo(mRoot);
         DestructionObserver signInObserver = mSigninPromo.getObserver();
         if (signInObserver != null) mNewTabPageManager.addDestructionObserver(signInObserver);
 
@@ -297,9 +297,7 @@ public void onCategoryStatusChanged(@CategoryInt int category, @CategoryStatusEn
                 return;
 
             case CategoryStatus.SIGNED_OUT:
-                resetSection(category, status, /*alwaysAllowEmptySections=*/false);
-                return;
-
+                // TODO(dgn): We currently don't have any case where we enter this state.

[Bernhard Bauer, 2016/11/21 15:48:15]

assert false then?

[dgn, 2016/11/21 16:22:07]

It can be changed by variations
(https://cs.chromium.org/chromium/src/components/ntp_snippets/remote/ntp_snipp...),
so I don't want to break that code path. 

But what should we do about this in the future? Show the sign in promo if it has
been dismissed?

             default:
                 mSections.get(category).setStatus(status);
                 return;
@@ -313,6 +311,11 @@ public void onSuggestionInvalidated(@CategoryInt int category, String idWithinCa
     }
 
     @Override
+    public void onFullRefreshRequired() {
+        resetSections(/*alwaysAllowEmptySections=*/false);
+    }
+
+    @Override
     @ItemViewType
     public int getItemViewType(int position) {
         return mRoot.getItemViewType(position);