Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2519033002: [debugger] remove obsolete test. (Closed)

Created:
4 years, 1 month ago by Yang
Modified:
4 years, 1 month ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] remove obsolete test. This test tests a code path that's being deprecated. There is no point in migrating it to the new debugger API. R=jgruber@chromium.org BUG=v8:5530 Committed: https://crrev.com/330ecc82cb1b0f956ab6cc6b2b71f6d532f1537e Cr-Commit-Position: refs/heads/master@{#41146}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -76 lines) Patch
D test/debugger/debug/regress/regress-94873.js View 1 chunk +0 lines, -76 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yang
4 years, 1 month ago (2016-11-21 13:35:19 UTC) #1
jgruber
lgtm
4 years, 1 month ago (2016-11-21 13:42:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519033002/1
4 years, 1 month ago (2016-11-21 13:59:28 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 14:32:33 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 14:32:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/330ecc82cb1b0f956ab6cc6b2b71f6d532f1537e
Cr-Commit-Position: refs/heads/master@{#41146}

Powered by Google App Engine
This is Rietveld 408576698