Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Issue 251903008: Fix incorrect config id being associated with post splice buffer. (Closed)

Created:
6 years, 7 months ago by DaleCurtis
Modified:
6 years, 7 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Fix incorrect config id being associated with post splice buffer. The code was using splice_buffers_index_ >= splice_buffer.size() to indicate that all pre splice buffers have been handed out. However this meant that the config change after handing out all pre splice buffers would incorrectly use the config id of the splice container instead of the last buffer (which is the first post splice buffer). See GetConfigId() for more details. This change fixes several tests and adds a new one to catch this explicitly. BUG=334493 TEST=new unittests, fixed existing tests! Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267098

Patch Set 1 #

Patch Set 2 : Fix ChunkDemuxer test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -28 lines) Patch
M content/renderer/media/webmediaplayer_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M media/filters/chunk_demuxer_unittest.cc View 1 2 chunks +0 lines, -14 lines 0 comments Download
M media/filters/source_buffer_stream.h View 1 chunk +3 lines, -0 lines 0 comments Download
M media/filters/source_buffer_stream.cc View 6 chunks +10 lines, -3 lines 0 comments Download
M media/filters/source_buffer_stream_unittest.cc View 7 chunks +46 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
DaleCurtis
6 years, 7 months ago (2014-04-29 02:24:07 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
6 years, 7 months ago (2014-04-29 15:49:13 UTC) #2
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 7 months ago (2014-04-29 17:22:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/251903008/1
6 years, 7 months ago (2014-04-29 17:24:11 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 18:56:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 18:56:37 UTC) #6
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 7 months ago (2014-04-29 20:19:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/251903008/20001
6 years, 7 months ago (2014-04-29 20:41:55 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 21:24:06 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 21:24:06 UTC) #10
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 7 months ago (2014-04-29 22:56:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/251903008/20001
6 years, 7 months ago (2014-04-29 22:58:47 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 05:48:06 UTC) #13
Message was sent while issue was closed.
Change committed as 267098

Powered by Google App Engine
This is Rietveld 408576698