Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(965)

Unified Diff: content/renderer/render_view_browsertest.cc

Issue 251903006: Attempt 2 to enable async data: URL loading. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix translation tests Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/test/render_view_test.cc ('k') | content/test/frame_load_waiter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_browsertest.cc
diff --git a/content/renderer/render_view_browsertest.cc b/content/renderer/render_view_browsertest.cc
index f0a880237ec5c94ca8dd74adb8b4878ed95efc91..b06151b93a6c9496d78be4bb62485f7ff2baa79a 100644
--- a/content/renderer/render_view_browsertest.cc
+++ b/content/renderer/render_view_browsertest.cc
@@ -35,6 +35,7 @@
#include "content/renderer/render_view_impl.h"
#include "content/shell/browser/shell.h"
#include "content/shell/browser/shell_browser_context.h"
+#include "content/test/frame_load_waiter.h"
#include "content/test/mock_keyboard.h"
#include "net/base/net_errors.h"
#include "net/cert/cert_status_flags.h"
@@ -2014,7 +2015,8 @@ TEST_F(RenderViewImplTest, NavigateFrame) {
nav_params.page_id = -1;
nav_params.frame_to_navigate = "frame";
frame()->OnNavigate(nav_params);
- ProcessPendingMessages();
+ FrameLoadWaiter(
+ RenderFrame::FromWebFrame(frame()->GetWebFrame()->firstChild())).Wait();
// Copy the document content to std::wstring and compare with the
// expected result.
@@ -2164,7 +2166,8 @@ TEST_F(SuppressErrorPageTest, MAYBE_DoesNotSuppress) {
// An error occurred.
view()->main_render_frame()->didFailProvisionalLoad(web_frame, error);
- ProcessPendingMessages();
+ // The error page itself is loaded asynchronously.
+ FrameLoadWaiter(frame()).Wait();
const int kMaxOutputCharacters = 22;
EXPECT_EQ("A suffusion of yellow.",
base::UTF16ToASCII(web_frame->contentAsText(kMaxOutputCharacters)));
@@ -2249,7 +2252,7 @@ TEST_F(RenderViewImplTest, SendProgressCompletionUpdates) {
EXPECT_EQ(0.1, progress_value.a);
render_thread_->sink().ClearMessages();
- ProcessPendingMessages();
+ FrameLoadWaiter(frame()).Wait();
// The data url has loaded, so we should see a progress change to 1.0 (done)
// and a stop notification.
« no previous file with comments | « content/public/test/render_view_test.cc ('k') | content/test/frame_load_waiter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698