content/public/test/frame_load_waiter.h - Issue 251903006: Attempt 2 to enable async data: URL loading.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/test/frame_load_waiter.h

Issue 251903006: Attempt 2 to enable async data: URL loading. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Better fix for BrowserPlugin tests from lazyboy@ Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.
	jam 2014/04/30 16:08:19 note: the guidelines for what goes in content/publ note: the guidelines for what goes in content/public/test and content/test are the same as other Content APIs: i.e. stuff should go in content/public/test if it's used by a higher module (chrome, components...), otherwise it should go into content/test in this particular case, this class is only used by one test, so you should inline it in that cc file until we need it in other tests dcheng 2014/04/30 17:56:06 Moved to content/test (RenderViewTest needs this a Show quoted text On 2014/04/30 16:08:19, jam wrote: > note: the guidelines for what goes in content/public/test and content/test are > the same as other Content APIs: i.e. stuff should go in content/public/test if > it's used by a higher module (chrome, components...), otherwise it should go > into content/test > > in this particular case, this class is only used by one test, so you should > inline it in that cc file until we need it in other tests Moved to content/test (RenderViewTest needs this as well)
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "base/macros.h"

	6 #include "base/run_loop.h"

	7 #include "content/public/renderer/render_view_observer.h"

	8

	9 namespace content {

	10

	11 class FrameLoadWaiter : public content::RenderViewObserver {
	sky 2014/04/30 13:30:59 Add description. Add description. dcheng 2014/04/30 17:56:06 Done. Show quoted text On 2014/04/30 13:30:59, sky wrote: > Add description. Done.
	12 public:

	13 explicit FrameLoadWaiter(RenderView* view);

	14 void Wait();

	15

	16 private:

	17 virtual void DidFinishLoad(blink::WebLocalFrame* frame) OVERRIDE;

	18

	19 base::RunLoop run_loop_;

	20

	21 DISALLOW_COPY_AND_ASSIGN(FrameLoadWaiter);

	22 };

	23

	24 } // namespace content

OLD	NEW

« no previous file with comments | « content/content_tests.gypi ('k') | content/public/test/frame_load_waiter.cc » ('j') | content/renderer/render_view_browsertest.cc » ('J')