Issue 251903003: Explicitly include gyp_gen/android_framework_gyp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 251903003: Explicitly include gyp_gen/android_framework_gyp. (Closed)

Created:
6 years, 7 months ago by scroggo

Modified:
6 years, 7 months ago

Reviewers:
epoger

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@angle

Visibility:
Public.

More Reviews

Description

Explicitly include gyp_gen/android_framework_gyp. Add __init__.py to gyp_gen and explicitly include android_framework_gyp from there. Fixes a bug where after moving that file, python was looking for it in its old location, where there was a compiled version of the file. BUG=skia:2468 Committed: http://code.google.com/p/skia/source/detail?r=14427

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -12 lines)			Patch
M	platform_tools/android/bin/gyp_to_android.py	View	1 chunk	+9 lines, -9 lines	0 comments	Download
A +	platform_tools/android/gyp_gen/__init__.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	platform_tools/android/tests/android_framework_gyp_tests.py	View	2 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

epoger

LGTM if it passes the Housekeeper-PerCommit-Trybot (which I just launched on this CL)

6 years, 7 months ago (2014-04-28 20:35:00 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/251903003/1

6 years, 7 months ago (2014-04-29 00:30:19 UTC) #4

Message was sent while issue was closed.

Change committed as 14427

Expand Messages | Collapse Messages