Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2519023002: Minor PolicyStatusProvider fixes (Closed)

Created:
4 years, 1 month ago by Thiemo Nagel
Modified:
4 years, 1 month ago
Reviewers:
Dan Beam
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor PolicyStatusProvider fixes Follow-up to https://codereview.chromium.org/2486813002/. BUG=656558 Committed: https://crrev.com/91cc209158c160afcfd6ddaccdbcc6a201db1f54 Cr-Commit-Position: refs/heads/master@{#433833}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/ui/webui/policy_ui_handler.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
Thiemo Nagel
Hi Dan, this is the follow-up to https://codereview.chromium.org/2486813002/, could you please take a look? Thank ...
4 years, 1 month ago (2016-11-21 13:32:23 UTC) #2
Dan Beam
lgtm
4 years, 1 month ago (2016-11-22 02:26:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519023002/1
4 years, 1 month ago (2016-11-22 06:45:34 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/266929)
4 years, 1 month ago (2016-11-22 07:24:27 UTC) #7
Thiemo Nagel
https://codereview.chromium.org/2519023002/diff/1/chrome/browser/ui/webui/policy_ui_handler.cc File chrome/browser/ui/webui/policy_ui_handler.cc (right): https://codereview.chromium.org/2519023002/diff/1/chrome/browser/ui/webui/policy_ui_handler.cc#newcode83 chrome/browser/ui/webui/policy_ui_handler.cc:83: // Their order has to follow the order of ...
4 years, 1 month ago (2016-11-22 10:55:09 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519023002/20001
4 years, 1 month ago (2016-11-22 10:55:18 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-22 10:59:00 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 11:02:22 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/91cc209158c160afcfd6ddaccdbcc6a201db1f54
Cr-Commit-Position: refs/heads/master@{#433833}

Powered by Google App Engine
This is Rietveld 408576698