|
|
Chromium Code Reviews|
Created:
4 years, 1 month ago by Thiemo Nagel Modified:
4 years, 1 month ago Reviewers:
Dan Beam CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMinor PolicyStatusProvider fixes
Follow-up to https://codereview.chromium.org/2486813002/.
BUG=656558
Committed: https://crrev.com/91cc209158c160afcfd6ddaccdbcc6a201db1f54
Cr-Commit-Position: refs/heads/master@{#433833}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Fix test #Messages
Total messages: 19 (11 generated)
tnagel@chromium.org changed reviewers: + dbeam@chromium.org
Hi Dan, this is the follow-up to https://codereview.chromium.org/2486813002/, could you please take a look? Thank you and kind regards, Thiemo
lgtm
The CQ bit was checked by tnagel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by tnagel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tnagel@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org Link to the patchset: https://codereview.chromium.org/2519023002/#ps20001 (title: "Fix test")
https://codereview.chromium.org/2519023002/diff/1/chrome/browser/ui/webui/pol... File chrome/browser/ui/webui/policy_ui_handler.cc (right): https://codereview.chromium.org/2519023002/diff/1/chrome/browser/ui/webui/pol... chrome/browser/ui/webui/policy_ui_handler.cc:83: // Their order has to follow the order of the policy::PolicySource enum. Actually I was too mechanical here. The order needs to match that of the PolicySource enum.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479812100449220,
"parent_rev": "85fee106abc263f5c427a2f771126470df009b8a", "commit_rev":
"3365d5c3fbf733073a8695858867b9791a5945a4"}
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Minor PolicyStatusProvider fixes Follow-up to https://codereview.chromium.org/2486813002/. BUG=656558 ========== to ========== Minor PolicyStatusProvider fixes Follow-up to https://codereview.chromium.org/2486813002/. BUG=656558 Committed: https://crrev.com/91cc209158c160afcfd6ddaccdbcc6a201db1f54 Cr-Commit-Position: refs/heads/master@{#433833} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/91cc209158c160afcfd6ddaccdbcc6a201db1f54 Cr-Commit-Position: refs/heads/master@{#433833} |
