Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2519003002:
[profiler] collect more source positions when debugger is active. (Closed)
Description[profiler] collect more source positions when debugger is active.
In order for profiles of optimized code to have accurate source
positions, we need to prepare for this when compiling. If the profiler
is enabled late, this may be missing, leading to inaccurate profile
data. A compromise to solve this is to prepare for accurate positions if
the debugger (and therefore DevTools) is active, even if we are not
currently capturing a profile.
The alternative is to deopt everything upon profiling, but that would
affect the profile significantly.
R=alph@chromium.org, bmeurer@chromium.org, neis@chromium.org, tebbi@chromium.org
Committed: https://crrev.com/418142b5a032a9f1d47eb614b00858a67c369661
Cr-Commit-Position: refs/heads/master@{#41217}
Patch Set 1 #Patch Set 2 : include #Messages
Total messages: 20 (14 generated)
Description was changed from ========== [profiler] collect more source positions when debugger is active. In order for profiles of optimized code to have accurate source positions, we need to prepare for this when compiling. If the profiler is enabled late, this may be missing, leading to inaccurate profile data. A compromise to solve this is to prepare for accurate positions if the debugger (and therefore DevTools) is active, even if we are not currently capturing a profile. R=alph@chromium.org, bmeurer@chromium.org, neis@chromium.org, tebbi@chromium.org ========== to ========== [profiler] collect more source positions when debugger is active. In order for profiles of optimized code to have accurate source positions, we need to prepare for this when compiling. If the profiler is enabled late, this may be missing, leading to inaccurate profile data. A compromise to solve this is to prepare for accurate positions if the debugger (and therefore DevTools) is active, even if we are not currently capturing a profile. The alternative is to deopt everything upon profiling, but that would affect the profile significantly. R=alph@chromium.org, bmeurer@chromium.org, neis@chromium.org, tebbi@chromium.org ==========
lgtm
lgtm
The CQ bit was checked by yangguo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...) v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/16527) v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...) v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
The CQ bit was checked by yangguo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yangguo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from neis@chromium.org, tebbi@chromium.org Link to the patchset: https://codereview.chromium.org/2519003002/#ps20001 (title: "include")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479903220688970,
"parent_rev": "72d0635cf814f14781803765c97021acd450ed80", "commit_rev":
"a7ed77566a6d646f7fc492e163b640b0088a6a61"}
Message was sent while issue was closed.
Description was changed from ========== [profiler] collect more source positions when debugger is active. In order for profiles of optimized code to have accurate source positions, we need to prepare for this when compiling. If the profiler is enabled late, this may be missing, leading to inaccurate profile data. A compromise to solve this is to prepare for accurate positions if the debugger (and therefore DevTools) is active, even if we are not currently capturing a profile. The alternative is to deopt everything upon profiling, but that would affect the profile significantly. R=alph@chromium.org, bmeurer@chromium.org, neis@chromium.org, tebbi@chromium.org ========== to ========== [profiler] collect more source positions when debugger is active. In order for profiles of optimized code to have accurate source positions, we need to prepare for this when compiling. If the profiler is enabled late, this may be missing, leading to inaccurate profile data. A compromise to solve this is to prepare for accurate positions if the debugger (and therefore DevTools) is active, even if we are not currently capturing a profile. The alternative is to deopt everything upon profiling, but that would affect the profile significantly. R=alph@chromium.org, bmeurer@chromium.org, neis@chromium.org, tebbi@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [profiler] collect more source positions when debugger is active. In order for profiles of optimized code to have accurate source positions, we need to prepare for this when compiling. If the profiler is enabled late, this may be missing, leading to inaccurate profile data. A compromise to solve this is to prepare for accurate positions if the debugger (and therefore DevTools) is active, even if we are not currently capturing a profile. The alternative is to deopt everything upon profiling, but that would affect the profile significantly. R=alph@chromium.org, bmeurer@chromium.org, neis@chromium.org, tebbi@chromium.org ========== to ========== [profiler] collect more source positions when debugger is active. In order for profiles of optimized code to have accurate source positions, we need to prepare for this when compiling. If the profiler is enabled late, this may be missing, leading to inaccurate profile data. A compromise to solve this is to prepare for accurate positions if the debugger (and therefore DevTools) is active, even if we are not currently capturing a profile. The alternative is to deopt everything upon profiling, but that would affect the profile significantly. R=alph@chromium.org, bmeurer@chromium.org, neis@chromium.org, tebbi@chromium.org Committed: https://crrev.com/418142b5a032a9f1d47eb614b00858a67c369661 Cr-Commit-Position: refs/heads/master@{#41217} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/418142b5a032a9f1d47eb614b00858a67c369661 Cr-Commit-Position: refs/heads/master@{#41217} |
