Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: chrome/browser/android/search_geolocation_disclosure_tab_helper.h

Issue 2518963002: Record metric of geo permission before and after showing the disclosure. (Closed)
Patch Set: Feedback 2 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/search_geolocation_disclosure_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/search_geolocation_disclosure_tab_helper.h
diff --git a/chrome/browser/android/search_geolocation_disclosure_tab_helper.h b/chrome/browser/android/search_geolocation_disclosure_tab_helper.h
index b121eddeba2ce87250117e70a00bc40375036910..00ed39c0722171896bb475164c4b3221098818d9 100644
--- a/chrome/browser/android/search_geolocation_disclosure_tab_helper.h
+++ b/chrome/browser/android/search_geolocation_disclosure_tab_helper.h
@@ -35,7 +35,12 @@ class SearchGeolocationDisclosureTabHelper
friend class content::WebContentsUserData<
SearchGeolocationDisclosureTabHelper>;
- void MaybeShowDefaultSearchGeolocationDisclosure(GURL gurl);
+ void MaybeShowDefaultSearchGeolocationDisclosure(const GURL& gurl);
+
+ // Record metrics, once per client, of the permission state before and after
+ // the disclosure has been shown.
+ void RecordPreDisclosureMetrics(const GURL& gurl);
+ void RecordPostDisclosureMetrics(const GURL& gurl);
Profile* GetProfile();
bool consistent_geolocation_enabled_;
« no previous file with comments | « no previous file | chrome/browser/android/search_geolocation_disclosure_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698