tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 3c5a1e7a27f2d541a1ffe549b60139e8178fa8c3..1376306a3ca98a409f95e36c0b157dba8ef65eb0 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -19001,6 +19001,24 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="GeolocationDisclosure.PostDisclosurePermission">

[Ilya Sherman, 2016/11/22 22:36:16]

Please add an enum attribute (and ditto below).

[benwells, 2016/11/23 02:31:22]

Done.

+  <owner>benwells@chromium.org</owner>
+  <summary>
+    Records the geolocation permission for the default search engine's origin
+    after the search geolocation disclosure has been shown and won't be shown
+    again. This metric is only recorded once per client.
+  </summary>
+</histogram>
+
+<histogram name="GeolocationDisclosure.PreDisclosurePermission">
+  <owner>benwells@chromium.org</owner>
+  <summary>
+    Records the geolocation permission for the default search engine's origin
+    before the search geolocation disclosure has been shown. This metric is only

[Ilya Sherman, 2016/11/22 22:36:17]

"before the search geolocation disclosure has been shown" gives a lot of wiggle
room -- does this actually mean "immediately before"?  If so, please add that
word in.  If not, could this be more specific?

[benwells, 2016/11/23 02:31:22]

I made it immediately before, and updated the comment here.

+    recorded once per client.
+  </summary>
+</histogram>
+
 <histogram name="GoogleNow.Card.Button.Clicked0" enum="GoogleNowCardTypeId">
   <owner>robliao@chromium.org</owner>
   <owner>skare@chromium.org</owner>