tools/metrics/histograms/histograms.xml - Issue 2518963002: Record metric of geo permission before and after showing the disclosure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2518963002: Record metric of geo permission before and after showing the disclosure. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 3c5a1e7a27f2d541a1ffe549b60139e8178fa8c3..4e8cf4ec6c044bb6e3ac512041bd832e798a3264 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -19001,6 +19001,22 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="GeolocationDisclosure.PostDisclosurePermission">

+ <owner>benwells@chromium.org</owner>

+ <summary>

+ Records the geolocation permission for the default search engine's origin

+ after the search geolocation disclosure has been shown.

raymes 2016/11/22 01:54:00 It could be useful to note this is only recorded o

benwells 2016/11/22 02:23:08 Done.

+ </summary>

+</histogram>

+<histogram name="GeolocationDisclosure.PreDisclosurePermission">

+ <owner>benwells@chromium.org</owner>

+ <summary>

+ Records the geolocation permission for the default search engine's origin

+ before the search geolocation disclosure has been shown.

raymes 2016/11/22 01:54:00 nit: similarly here

benwells 2016/11/22 02:23:07 Done.

+ </summary>

+</histogram>

<owner>robliao@chromium.org</owner>

<owner>skare@chromium.org</owner>