Add multiple selection support to chooser on desktops

chrome/browser/ui/views/chooser_content_view.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/chooser_content_view.h"
 
 #include "base/memory/ptr_util.h"
 #include "base/numerics/safe_conversions.h"
 #include "chrome/grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
@@ skipping 46 matching lines @@
   help_text_range_ = gfx::Range(offsets[0], offsets[0] + help_text_.size());
   re_scan_text_range_ =
       gfx::Range(offsets[1], offsets[1] + re_scan_text.size());
   chooser_controller_->set_view(this);
   std::vector<ui::TableColumn> table_columns;
   table_columns.push_back(ui::TableColumn());
   table_view_ = new views::TableView(
       this, table_columns,
       chooser_controller_->ShouldShowIconBeforeText() ? views::ICON_AND_TEXT
                                                       : views::TEXT_ONLY,
-      true /* single_selection */);
+      !chooser_controller_->AllowMultipleSelection() /* single_selection */);
   table_view_->set_select_on_remove(false);
   table_view_->SetObserver(table_view_observer);
   table_view_->SetEnabled(chooser_controller_->NumOptions() > 0);
 
   table_parent_ = table_view_->CreateParentIfNecessary();
   AddChildView(table_parent_);
 
   throbber_ = new views::Throbber();
   throbber_->SetVisible(false);
   AddChildView(throbber_);
@@ skipping 200 matching lines @@
              ? chooser_controller_->GetOkButtonLabel()
              : l10n_util::GetStringUTF16(IDS_DEVICE_CHOOSER_CANCEL_BUTTON_TEXT);
 }
 
 bool ChooserContentView::IsDialogButtonEnabled(ui::DialogButton button) const {
   return button != ui::DIALOG_BUTTON_OK ||
          !table_view_->selection_model().empty();
 }
 
 void ChooserContentView::Accept() {
-  chooser_controller_->Select(table_view_->selection_model().active());
+  for (int index : table_view_->selection_model().selected_indices())
+    chooser_controller_->Select(index);

[sky, 2016/11/22 04:37:35]

Isn't Select() a one time type call? I would expect you to pass it all the
selected indices, not just one.

[juncai, 2016/11/22 19:07:00]

Done.

 }
 
 void ChooserContentView::Cancel() {
   chooser_controller_->Cancel();
 }
 
 void ChooserContentView::Close() {
   chooser_controller_->Close();
 }
 
 void ChooserContentView::UpdateTableView() {
   if (chooser_controller_->NumOptions() == 0) {
     table_view_->OnModelChanged();
     table_view_->SetEnabled(false);
   } else {
     table_view_->SetEnabled(true);
   }
 }
 
 void ChooserContentView::SetGetHelpAndReScanLink() {
   footnote_link_->SetText(help_and_re_scan_text_);
   footnote_link_->AddStyleRange(
       help_text_range_, views::StyledLabel::RangeStyleInfo::CreateForLink());
   footnote_link_->AddStyleRange(
       re_scan_text_range_, views::StyledLabel::RangeStyleInfo::CreateForLink());
 }