Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2518883002:
Whitespace change: CQ still works. (Closed)
|
Created:
4 years, 1 month ago by tandrii(chromium) Modified:
4 years, 1 month ago CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionWhitespace change: CQ still works.
TBR=machenbach@chromium.org
NOTRY=True
NOPRESUBMIT=True
Committed: https://crrev.com/700f94331f01386b5238ac758cf96bff108a7164
Cr-Commit-Position: refs/heads/master@{#41124}
Patch Set 1 #
Messages
Total messages: 26 (13 generated)
The CQ bit was checked by tandrii@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-v8-committers". Note that this has nothing to do with OWNERS files.
On 2016/11/20 14:50:19, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. > CQ run can only be started by full committers or once the patch has > received an L-G-T-M from a full committer. > Even if an L-G-T-M may have been provided, it was from a non-committer, > _not_ a full super star committer. > Committers are members of the group "project-v8-committers". > Note that this has nothing to do with OWNERS files. temporary elevated my permissions: https://chrome-infra-auth.appspot.com/auth/groups#project-v8-committers
The CQ bit was checked by tandrii@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-v8-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was checked by tandrii@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-v8-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was checked by tandrii@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
damn CQ caching :(
The CQ bit was unchecked by tandrii@chromium.org
Description was changed from ========== Whitespace change: CQ still works. TBR=machenbach@chromium.org ========== to ========== Whitespace change: CQ still works. TBR=machenbach@chromium.org NOTRY=True NOPRESUBMIT=True ==========
lgtm
The CQ bit was checked by tandrii@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1479670294351900, "parent_rev":
["670f155e6f2b0a6e4b084b51859d8f025d5fdb44", null], "commit_rev":
["9645f6f426c81d5c37045703bca5c8e696aa5699", null]}
Message was sent while issue was closed.
Description was changed from ========== Whitespace change: CQ still works. TBR=machenbach@chromium.org NOTRY=True NOPRESUBMIT=True ========== to ========== Whitespace change: CQ still works. TBR=machenbach@chromium.org NOTRY=True NOPRESUBMIT=True ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Whitespace change: CQ still works. TBR=machenbach@chromium.org NOTRY=True NOPRESUBMIT=True ========== to ========== Whitespace change: CQ still works. TBR=machenbach@chromium.org NOTRY=True NOPRESUBMIT=True Committed: https://crrev.com/700f94331f01386b5238ac758cf96bff108a7164 Cr-Commit-Position: refs/heads/master@{#41124} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/700f94331f01386b5238ac758cf96bff108a7164 Cr-Commit-Position: refs/heads/master@{#41124} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
