Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2518873002: Use an import prefix in the analysis server tests; this fixes some issues conflicting with the (Closed)

Created:
4 years, 1 month ago by devoncarew
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use an import prefix in the analysis server tests; this fixes some issues conflicting with the 'equals' symbol in the 1.4.0 version of package:path. BUG= R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/f16a0a2a4d0ef98f4329b795f12b8be3788855a6

Patch Set 1 #

Patch Set 2 : use path prefix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -60 lines) Patch
M pkg/analysis_server/test/context_manager_test.dart View 1 32 chunks +48 lines, -49 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/get_hover_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/package_root_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/single_context_manager_test.dart View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
devoncarew
4 years, 1 month ago (2016-11-20 07:50:20 UTC) #2
scheglov
lgtm Is there a reason not to use consistently "show X, Y" or "as pathos" ...
4 years, 1 month ago (2016-11-20 17:11:08 UTC) #3
devoncarew
Being consistent w/ using an import prefix makes sense. It looks like there are slightly ...
4 years, 1 month ago (2016-11-20 18:10:01 UTC) #4
devoncarew
(updated)
4 years, 1 month ago (2016-11-20 18:24:11 UTC) #5
scheglov
Still LGTM.
4 years, 1 month ago (2016-11-20 18:25:39 UTC) #6
devoncarew
Committed patchset #2 (id:20001) manually as f16a0a2a4d0ef98f4329b795f12b8be3788855a6 (presubmit successful).
4 years, 1 month ago (2016-11-20 18:26:27 UTC) #8
Brian Wilkerson
4 years, 1 month ago (2016-11-21 14:49:49 UTC) #9
Message was sent while issue was closed.
lgtm

Personally I dislike "pathos" because I always read it as the word rather than
"path OS".

Powered by Google App Engine
This is Rietveld 408576698