Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 2518843002: Put 'finer grained invalidation' back behind the flag. (Closed)

Created:
4 years, 1 month ago by scheglov
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Put 'finer grained invalidation' back behind the flag. Unfortunately we see exceptions in the wild, both internally and externally :-( For example https://github.com/dart-lang/sdk/issues/27770 R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/2301e67340ec89d41b241960fa7e87c3735cdd15

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/analysis_server/lib/src/server/driver.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 1 month ago (2016-11-19 16:27:25 UTC) #1
Paul Berry
lgtm
4 years, 1 month ago (2016-11-21 13:58:21 UTC) #2
Brian Wilkerson
lgtm
4 years, 1 month ago (2016-11-21 15:57:52 UTC) #3
scheglov
4 years, 1 month ago (2016-11-21 16:33:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2301e67340ec89d41b241960fa7e87c3735cdd15 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698