Issue 251883002: Replace FileUtilProxy with FileProxy on NaClBrowser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 251883002: Replace FileUtilProxy with FileProxy on NaClBrowser. (Closed)

Created:
6 years, 8 months ago by rvargas (doing something else)

Modified:
6 years, 7 months ago

Reviewers:
Mark Seaborn

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Replace FileUtilProxy with FileProxy on NaClBrowser. BUG=322664 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267806

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix indentation #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -29 lines)			Patch
M	components/nacl/browser/nacl_browser.h	View		5 chunks	+8 lines, -6 lines	0 comments	Download
M	components/nacl/browser/nacl_browser.cc	View	1	5 chunks	+17 lines, -20 lines	0 comments	Download
M	components/nacl/browser/nacl_process_host.cc	View		1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mark Seaborn

LGTM, with the caveat that I'm not familiar with the base::File and base::FileProxy interfaces. https://codereview.chromium.org/251883002/diff/1/components/nacl/browser/nacl_browser.cc ...

6 years, 7 months ago (2014-04-30 17:55:24 UTC) #2

rvargas (doing something else)

The CQ bit was checked by rvargas@chromium.org

6 years, 7 months ago (2014-05-02 01:51:59 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/251883002/10001

6 years, 7 months ago (2014-05-02 01:52:36 UTC) #4

Message was sent while issue was closed.

Change committed as 267806

Expand Messages | Collapse Messages