Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2518733002: [Offline Pages] Remove timeout in test harness. (Closed)

Created:
4 years, 1 month ago by romax
Modified:
4 years, 1 month ago
Reviewers:
Pete Williamson
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline Pages] Remove timeout in test harness. Removes the timeout related code since there isn't a use case which would terminate test harness before it finishes offlining all the urls. BUG=666515 Committed: https://crrev.com/2656bba9e0f0cff3f12d0aa008ba91797ae53b9c Cr-Commit-Position: refs/heads/master@{#433362}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -29 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageSavePageLaterEvaluationTest.java View 9 chunks +11 lines, -17 lines 0 comments Download
M chrome/browser/android/offline_pages/evaluation/run_offline_page_evaluation_test.py View 6 chunks +3 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
romax
Pete PTAL, thanks!
4 years, 1 month ago (2016-11-19 00:13:16 UTC) #2
Pete Williamson
lgtm
4 years, 1 month ago (2016-11-19 00:26:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2518733002/1
4 years, 1 month ago (2016-11-19 00:33:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-19 01:04:54 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-19 01:08:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2656bba9e0f0cff3f12d0aa008ba91797ae53b9c
Cr-Commit-Position: refs/heads/master@{#433362}

Powered by Google App Engine
This is Rietveld 408576698