Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 251873003: linux: In diff mode, also print files with init function that calls 0 initializers. (Closed)

Created:
6 years, 8 months ago by Nico
Modified:
6 years, 8 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

linux: In diff mode, print files with init function that calls 0 initializers. clang writes two of these for some reason, and due to the script not printing these it took me a while to figure out why clang has initializers for two more files. BUG=360311 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266323

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M tools/linux/dump-static-initializers.py View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
6 years, 8 months ago (2014-04-25 23:29:51 UTC) #1
Lei Zhang
lgtm NOTRY=true ?
6 years, 8 months ago (2014-04-25 23:34:55 UTC) #2
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 8 months ago (2014-04-25 23:36:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/251873003/1
6 years, 8 months ago (2014-04-25 23:41:16 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-26 02:21:10 UTC) #5
Message was sent while issue was closed.
Change committed as 266323

Powered by Google App Engine
This is Rietveld 408576698