Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2521)

Unified Diff: appengine/findit/util_scripts/git_checkout/test/local_git_repository_test.py

Issue 2518663002: Converting various classes to namedtuples (Closed)
Patch Set: addressing nits Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/util_scripts/git_checkout/test/local_git_repository_test.py
diff --git a/appengine/findit/util_scripts/git_checkout/test/local_git_repository_test.py b/appengine/findit/util_scripts/git_checkout/test/local_git_repository_test.py
index c5c8c2f9cb25fd97cb5b7fc6fa9aef5018f4f1af..c0e2804d3aa998996a617414f2e1cbbbd4fc8dd3 100644
--- a/appengine/findit/util_scripts/git_checkout/test/local_git_repository_test.py
+++ b/appengine/findit/util_scripts/git_checkout/test/local_git_repository_test.py
@@ -90,6 +90,7 @@ class LocalGitRepositoryTest(testing.AppengineTestCase):
'modify', 'src/a/b.py', 'src/a/b.py')],
'https://repo/path/+/revision', None, None)
self.mock(script_util, 'GetCommandOutput', lambda *_: output)
+ # TODO: compare the objects directly, rather than via ToDict
self.assertEqual(self.local_repo.GetChangeLog('revision').ToDict(),
expected_changelog.ToDict())

Powered by Google App Engine
This is Rietveld 408576698