Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2962)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: appengine/findit/crash/test/stacktrace_test.py

Issue 2518663002: Converting various classes to namedtuples (Closed)
Patch Set: addressing nits Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/crash/test/results_test.py ('k') | appengine/findit/lib/gitiles/change_log.py » ('j') | appengine/findit/lib/gitiles/change_log.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/crash/test/stacktrace_test.py
diff --git a/appengine/findit/crash/test/stacktrace_test.py b/appengine/findit/crash/test/stacktrace_test.py
index e6955a9a3e4bc743e11a235299389bf7d49c37ec..f0a5ace6fa66b612615efa5205101f5f3da021bb 100644
--- a/appengine/findit/crash/test/stacktrace_test.py
+++ b/appengine/findit/crash/test/stacktrace_test.py
@@ -27,10 +27,10 @@ class CallStackTest(StacktraceTestSuite):
frame = StackFrame(0, 'src/', 'func', 'f.cc', 'src/f.cc', [])
self.assertEqual(frame.BlameUrl('1'), None)
- frame.repo_url = 'https://repo_url'
+ frame = frame._replace(repo_url = 'https://repo_url')
self.assertEqual(frame.BlameUrl('1'), 'https://repo_url/+blame/1/f.cc')
- frame.crashed_line_numbers = [9, 10]
+ frame = frame._replace(crashed_line_numbers = [9, 10])
self.assertEqual(frame.BlameUrl('1'), 'https://repo_url/+blame/1/f.cc#9')
def testFrameListInitCallStack(self):
« no previous file with comments | « appengine/findit/crash/test/results_test.py ('k') | appengine/findit/lib/gitiles/change_log.py » ('j') | appengine/findit/lib/gitiles/change_log.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698