Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: appengine/findit/crash/test/callstack_test.py

Issue 2518663002: Converting various classes to namedtuples (Closed)
Patch Set: addressing nits Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/crash/test/callstack_test.py
diff --git a/appengine/findit/crash/test/callstack_test.py b/appengine/findit/crash/test/callstack_test.py
deleted file mode 100644
index eda0225ed665ff0397c7ad7304079fb3da09b334..0000000000000000000000000000000000000000
--- a/appengine/findit/crash/test/callstack_test.py
+++ /dev/null
@@ -1,98 +0,0 @@
-# Copyright 2016 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-from common.dependency import Dependency
-from crash.callstack import StackFrame, CallStack
-from crash.test.stacktrace_test_suite import StacktraceTestSuite
-from crash.type_enums import CallStackFormatType, CallStackLanguageType
-
-
-class CallStackTest(StacktraceTestSuite):
-
- def testStackFrameToString(self):
- self.assertEqual(
- StackFrame(0, 'src/', 'func', 'f.cc', 'src/f.cc', []).ToString(),
- '#0 in func @ f.cc')
- self.assertEqual(
- StackFrame(0, 'src/', 'func', 'f.cc', 'src/f.cc', [1]).ToString(),
- '#0 in func @ f.cc:1')
- self.assertEqual(
- StackFrame(0, 'src/', 'func', 'f.cc', 'src/f.cc', [1, 2]).ToString(),
- '#0 in func @ f.cc:1:1')
-
- def testBlameUrlForStackFrame(self):
- frame = StackFrame(0, 'src/', 'func', 'f.cc', 'src/f.cc', [])
- self.assertEqual(frame.BlameUrl('1'), None)
-
- frame.repo_url = 'https://repo_url'
- self.assertEqual(frame.BlameUrl('1'), 'https://repo_url/+blame/1/f.cc')
-
- frame.crashed_line_numbers = [9, 10]
- self.assertEqual(frame.BlameUrl('1'), 'https://repo_url/+blame/1/f.cc#9')
-
- def testFrameListInitCallStack(self):
- stack = CallStack(0)
- stack.extend([StackFrame(0, 'src/', '', 'func', 'f.cc', [2])])
-
- copy_stack = CallStack(stack.priority, frame_list=stack)
- self._VerifyTwoCallStacksEqual(copy_stack, stack)
-
- def testParseLineForJavaCallstackFormat(self):
- stack = CallStack(0, CallStackFormatType.JAVA)
-
- stack.ParseLine('dummy line', {})
- self.assertEqual(stack, [])
-
- deps = {'org/': Dependency('org/', 'https://repo', '1')}
- stack.ParseLine(' at org.a.b(a.java:609)', deps)
- self._VerifyTwoStackFramesEqual(
- stack[0],
- StackFrame(0, 'org/', 'org.a.b', 'a.java', 'org/a.java', [609]))
-
- def testParseLineForSyzyasanCallstackFormat(self):
- stack = CallStack(0, CallStackFormatType.SYZYASAN)
-
- stack.ParseLine('dummy line', {})
- self.assertEqual(stack, [])
-
- deps = {'src/content/': Dependency('src/content/', 'https://repo', '1')}
- stack.ParseLine('c::p::n [src/content/e.cc @ 165]', deps)
- self._VerifyTwoStackFramesEqual(
- stack[0],
- StackFrame(
- 0, 'src/content/', 'c::p::n', 'e.cc', 'src/content/e.cc', [165]))
-
- def testParseLineForDefaultCallstackFormat(self):
- stack = CallStack(0, CallStackFormatType.DEFAULT)
-
- stack.ParseLine('dummy line', {})
- self.assertEqual(stack, [])
-
- stack.ParseLine('#dummy line', {})
- self.assertEqual(stack, [])
-
- deps = {'tp/webrtc/': Dependency('tp/webrtc/', 'https://repo', '1')}
- stack.ParseLine('#0 0x52617a in func0 tp/webrtc/a.c:38:3', deps)
- self._VerifyTwoStackFramesEqual(
- stack[0],
- StackFrame(
- 0, 'tp/webrtc/', 'func0', 'a.c', 'tp/webrtc/a.c', [38, 39, 40, 41]))
-
- stack.ParseLine('#1 0x526 in func::func2::func3 tp/webrtc/a.c:3:2', deps)
- self._VerifyTwoStackFramesEqual(
- stack[1],
- StackFrame(
- 1, 'tp/webrtc/', 'func::func2::func3', 'a.c', 'tp/webrtc/a.c',
- [3, 4, 5]))
-
- def testParseLineForFracasJavaStack(self):
- stack = CallStack(0, CallStackFormatType.DEFAULT,
- CallStackLanguageType.JAVA)
-
- stack.ParseLine('#0 0xxx in android.app.func app.java:2450', {})
- self._VerifyTwoStackFramesEqual(
- stack[0],
- StackFrame(
- 0, '', 'android.app.func', 'android/app.java',
- 'android/app.java', [2450]))

Powered by Google App Engine
This is Rietveld 408576698