Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2518643002: Add a complex reload test that rebases the root script path three times. (Closed)

Created:
4 years, 1 month ago by Cutch
Modified:
4 years, 1 month ago
Reviewers:
turnidge, rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a complex reload test that rebases the root script path three times. BUG= R=turnidge@google.com Committed: https://github.com/dart-lang/sdk/commit/8a7f7715f137859507f9a41ad97ad8c7f10cbcfe

Patch Set 1 #

Total comments: 2

Patch Set 2 : turnidge review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -2 lines) Patch
M runtime/observatory/lib/src/service/object.dart View 1 1 chunk +12 lines, -2 lines 0 comments Download
A runtime/observatory/tests/service/complex_reload/v1/main.dart View 1 chunk +14 lines, -0 lines 0 comments Download
A runtime/observatory/tests/service/complex_reload/v2/main.dart View 1 chunk +6 lines, -0 lines 0 comments Download
A runtime/observatory/tests/service/complex_reload/v3/main.dart View 1 chunk +6 lines, -0 lines 0 comments Download
A runtime/observatory/tests/service/complex_reload_test.dart View 1 1 chunk +85 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Cutch
4 years, 1 month ago (2016-11-18 19:15:21 UTC) #3
turnidge
lgtm w/ 1 comment https://codereview.chromium.org/2518643002/diff/1/runtime/observatory/lib/src/service/object.dart File runtime/observatory/lib/src/service/object.dart (right): https://codereview.chromium.org/2518643002/diff/1/runtime/observatory/lib/src/service/object.dart#newcode1337 runtime/observatory/lib/src/service/object.dart:1337: [Map<String, dynamic> params]) { I ...
4 years, 1 month ago (2016-11-18 19:23:10 UTC) #4
Cutch
https://codereview.chromium.org/2518643002/diff/1/runtime/observatory/lib/src/service/object.dart File runtime/observatory/lib/src/service/object.dart (right): https://codereview.chromium.org/2518643002/diff/1/runtime/observatory/lib/src/service/object.dart#newcode1337 runtime/observatory/lib/src/service/object.dart:1337: [Map<String, dynamic> params]) { On 2016/11/18 19:23:10, turnidge wrote: ...
4 years, 1 month ago (2016-11-18 20:23:19 UTC) #5
Cutch
4 years, 1 month ago (2016-11-18 20:24:08 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
8a7f7715f137859507f9a41ad97ad8c7f10cbcfe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698