Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2518623004: Removed leftover enums from WebGL 2.0 rendering context. (Closed)

Created:
4 years, 1 month ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 1 month ago
CC:
blink-reviews, chromium-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed leftover enums from WebGL 2.0 rendering context. Also includes needed WebGL conformance roll: Roll WebGL 453428f..d12037a https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/453428f..d12037a BUG=666927 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/b368c8ec4a79496fb2816aa79d3e5c235a4843c4 Cr-Commit-Position: refs/heads/master@{#433573}

Patch Set 1 #

Patch Set 2 : Updated global-interface-listing expected results. #

Patch Set 3 : Rebased to try to fix test failures. #

Patch Set 4 : Found and updated platform-specific expectations. #

Messages

Total messages: 42 (23 generated)
Ken Russell (switch to Gerrit)
PTAL
4 years, 1 month ago (2016-11-18 22:44:08 UTC) #3
Kai Ninomiya
lgtm
4 years, 1 month ago (2016-11-18 22:45:06 UTC) #6
Zhenyao Mo
On 2016/11/18 22:45:06, Kai Ninomiya wrote: > lgtm lgtm
4 years, 1 month ago (2016-11-18 22:48:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2518623004/1
4 years, 1 month ago (2016-11-18 22:55:13 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/184112)
4 years, 1 month ago (2016-11-18 23:40:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2518623004/1
4 years, 1 month ago (2016-11-18 23:58:37 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/335339)
4 years, 1 month ago (2016-11-19 00:46:35 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2518623004/1
4 years, 1 month ago (2016-11-19 01:05:22 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2518623004/1
4 years, 1 month ago (2016-11-19 19:37:42 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/335675)
4 years, 1 month ago (2016-11-19 21:20:36 UTC) #23
Zhenyao Mo
On 2016/11/19 21:20:36, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 1 month ago (2016-11-19 21:34:18 UTC) #24
Ken Russell (switch to Gerrit)
On 2016/11/19 21:34:18, Zhenyao Mo wrote: > On 2016/11/19 21:20:36, commit-bot: I haz the power ...
4 years, 1 month ago (2016-11-19 22:27:46 UTC) #25
Ken Russell (switch to Gerrit)
chrishtr or dglazkov or foolip or tkent: please review this small update to the WebGL ...
4 years, 1 month ago (2016-11-19 22:28:52 UTC) #27
chrishtr
lgtm
4 years, 1 month ago (2016-11-19 22:37:18 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2518623004/60001
4 years, 1 month ago (2016-11-20 04:18:03 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/184487)
4 years, 1 month ago (2016-11-20 05:38:30 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2518623004/60001
4 years, 1 month ago (2016-11-21 14:31:02 UTC) #38
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-21 17:10:38 UTC) #40
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 17:12:28 UTC) #42
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b368c8ec4a79496fb2816aa79d3e5c235a4843c4
Cr-Commit-Position: refs/heads/master@{#433573}

Powered by Google App Engine
This is Rietveld 408576698